Skip to content

Edited create_dataset arguments to handle strings in data#26

Open
rudyg3 wants to merge 35 commits into
mainfrom
FileWriteFix
Open

Edited create_dataset arguments to handle strings in data#26
rudyg3 wants to merge 35 commits into
mainfrom
FileWriteFix

Conversation

@rudyg3

@rudyg3 rudyg3 commented Apr 25, 2022

Copy link
Copy Markdown

Change here reflects a prior version of bigplanet. I'm not quite sure why this is needed, but without these arguments the HDF5 file cannot be created because it doesn't like to read strings.

@github-actions

github-actions Bot commented Apr 25, 2022

Copy link
Copy Markdown

Unit Test Results

10 tests  ±0   6 ✔️  - 4   1m 15s ⏱️ -17s
  1 suites ±0   0 💤 ±0 
  1 files   ±0   4 +4 

For more details on these failures, see this check.

Results for commit f1caa7a. ± Comparison against base commit 89c4938.

This pull request removes 10 and adds 10 tests. Note that renamed tests count towards both.
tests.Bpstatus.test_bpstatus ‑ test_bpstatus
tests.CreateHDF5.test_bpcreatehdf5 ‑ test_bpcreatehdf5
tests.ExtractArchive.test_bpextract ‑ test_bpextract
tests.ExtractFilterArchive.test_bpextractfilterarchive ‑ test_bpextract
tests.ExtractFilterRawData.test_bpextractfilterraw ‑ test_bpextract
tests.MD5CheckSum.test_bpmd5checksum ‑ test_bpextract
tests.SingleSim.test_singlesim ‑ test_singlesim
tests.Stats.test_bpstats ‑ test_bpstats
tests.UlyssesAggregated.test_UlyssesAggregated ‑ test_ulyssesaggregated
tests.UlyssesForward.test_bpulyssessforward ‑ test_ulyssesforward
tests.CreateHDF5.test_CreateHDF5 ‑ test_CreateHDF5
tests.ExtractArchive.test_ExtractArchive ‑ test_ExtractArchive
tests.ExtractFilterArchive.test_ExtractFilterArchive ‑ test_ExtractFilterArchive
tests.ExtractFilterRaw.test_ExtractFilterRaw ‑ test_ExtractFilterRaw
tests.MD5CheckSum.test_MD5CheckSum ‑ test_MD5CheckSum
tests.SingleSim.test_singlesim ‑ test_SingleSim
tests.Stats.test_Stats ‑ test_Stats
tests.Status.test_Status ‑ test_bpstatus
tests.UlyssesAggregated.test_UlyssesAggregated ‑ test_UlyssesAggregated
tests.UlyssesForward.test_UlyssesForward ‑ test_UlyssesForward

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants