[PLAT-7571] Updated ApiClient.mustache to handle large file uploads#69
Closed
anderssjoblom-vertex wants to merge 1 commit intomainfrom
Closed
[PLAT-7571] Updated ApiClient.mustache to handle large file uploads#69anderssjoblom-vertex wants to merge 1 commit intomainfrom
anderssjoblom-vertex wants to merge 1 commit intomainfrom
Conversation
|
Contributor
|
Is there some way to do this other than plopping that 2k-line file in here? I'm thinking about maintenance: for example, if there's a security or other update to that code, we can't just update a version number of a dependency, we'd have to grab that file and reapply our changes with a three-way merge. I know we have some similar problems elsewhere in this library, just hoping we can avoid adding more to that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This removes a "read the whole body into a string buffer" and to authenticate the multi-part data before sending it. This is not needed for a file upload and the custom mustache resolves that issue. The implementation is in the bottom of the file
The source of this file was taken from here: okhttp-gson
ApiClient.mustache
protected String requestBodyToString(RequestBody requestBody) throws ApiException { . . .Test Plan
This will be tested using the plm-integration-kernel
Release Notes
None
Possible Regressions
None expected