Skip to content

feat: landing page style update#5581

Merged
cuzz-venus merged 36 commits into
mainfrom
feat/landing-page
May 21, 2026
Merged

feat: landing page style update#5581
cuzz-venus merged 36 commits into
mainfrom
feat/landing-page

Conversation

@cuzz-venus
Copy link
Copy Markdown
Contributor

@cuzz-venus cuzz-venus commented May 8, 2026

Jira ticket(s)

VPD-1145

Changes

Landing — Hero

  • Moved primary Start now CTA from inside the Highest APY card to below the Venus TVL number, linking
    to Venus Core Market (sized to Figma: py-2 px-20).
  • Highest APY card now hidden below xl (1280px); desktop only.

NavBar — Markets / Others menus

  • Desktop: Markets / Others now open on hover (added an opt-in triggerOnHover prop to the shared
    Dropdown; other consumers unchanged).
  • Mobile hamburger: Markets is expanded by default (new defaultOpenOnMobile flag on SubMenu, set
    only on Markets).

Markets page

  • Header subtitle hidden on mobile.
  • Mobile Sort by select hidden — added disableCardsSorting to MarketTable, which derives a
    cardColumns array with sortRows stripped. TableCards then computes empty options and skips the
    select. Desktop column sorting and the other 4 MarketTable callers are unaffected.

@changeset-bot
Copy link
Copy Markdown

changeset-bot Bot commented May 8, 2026

🦋 Changeset detected

Latest commit: 643d22c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@venusprotocol/evm Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link
Copy Markdown

vercel Bot commented May 8, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
dapp-preview Ready Ready Preview May 20, 2026 4:08pm
dapp-testnet Ready Ready Preview May 20, 2026 4:08pm
venus.io Ready Ready Preview May 20, 2026 4:08pm

Request Review

@greptile-apps
Copy link
Copy Markdown

greptile-apps Bot commented May 8, 2026

Greptile Summary

This PR delivers a visual refresh of the landing page, navbar, and markets page: the "Start now" CTA moves below the Venus TVL figure on the hero, the Highest APY card is hidden below xl, navbar dropdowns open on hover at desktop widths, and the mobile Markets card sort select is suppressed.

  • Landing hero: TabContent is simplified (removes per-tab CTA and poolComptrollerContractAddress); the shared CTA now lives in Hero pointing to useGetMarketsPagePath.
  • Navbar: triggerOnHover added to Dropdown, defaultOpenOnMobile added to SubMenu so Markets opens by default in the mobile hamburger.
  • Markets / MarketTable: disableCardsSorting strips sortRows from card columns so TableCards produces an empty options list and skips the Sort-by Select.

Confidence Score: 5/5

Safe to merge — changes are scoped to UI layout, a new optional dropdown prop, and a table card-sorting guard; no data-flow or contract logic is altered.

All changed paths are presentational. The disableCardsSorting path is correctly wired through useMemo and the TableCards guard. The triggerOnHover hover-open logic is isolated behind the new prop with no effect on existing consumers. The only findings are a missing useMemo on a small derived array and a raw hex colour — neither affects runtime correctness.

No files require special attention.

Important Files Changed

Filename Overview
apps/evm/src/pages/Landing/Hero/HeroTabs/TabContent/Earnings/BarChart/index.tsx Adds per-bar fill coloring by embedding fill in data entries; styledData is recomputed on every render without useMemo. Also still uses raw hex #181D27 for bar fill color.
apps/evm/src/components/Dropdown/index.tsx Adds triggerOnHover prop — hover open/close via onMouseEnter/onMouseLeave; backdrop removed in hover mode. Previously flagged mobile modal concern remains.
apps/evm/src/containers/Layout/NavBar/MenuItem/index.tsx Switches XL dropdown to hover trigger and initialises mobile submenu open state from defaultOpenOnMobile. Removes the XL backdrop (no longer needed). Clean change.
apps/evm/src/containers/MarketTable/index.tsx Adds disableCardsSorting prop that strips sortRows from card columns, correctly causing TableCards to omit the Sort-by select. Memoised correctly.
apps/evm/src/pages/Landing/Hero/index.tsx Moves "Start now" CTA to below the TVL number using useGetMarketsPagePath, linking to Venus Core Market. Straightforward layout change.
apps/evm/src/pages/Landing/Hero/HeroTabs/TabContent/index.tsx Removes the per-tab "Start now" button and the poolComptrollerContractAddress prop; simplifies component to APY display only. Clean dead-code removal.
apps/evm/src/pages/Markets/Header/index.tsx Hides the pool description on mobile and fixes a pre-existing typo (text-1brtext-b1r).
apps/evm/src/pages/Markets/Tabs/Markets/index.tsx Adds disableCardsSorting to the Markets table to suppress the mobile Sort-by select. One-line change, correct usage.
apps/evm/src/pages/Landing/Hero/HeroTabs/index.tsx Hides the Highest APY card below xl via hidden xl:flex; removes poolComptrollerContractAddress from TabContent calls. Clean.

Reviews (3): Last reviewed commit: "feat: style update" | Re-trigger Greptile

Comment thread apps/evm/src/containers/Layout/NavBar/MenuItem/index.tsx
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 9, 2026

Coverage Report for ./apps/evm

Status Category Percentage Covered / Total
🔵 Lines 81.18% 45343 / 55854
🔵 Statements 81.18% 45343 / 55854
🔵 Functions 62.36% 648 / 1039
🔵 Branches 72.3% 5106 / 7062
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
apps/evm/src/components/Dropdown/index.tsx 69.33% 41.66% 0% 69.33% 49-51, 59-83
apps/evm/src/components/Table/TableCards/index.tsx 89.71% 96% 33.33% 89.71% 59-70, 118
apps/evm/src/containers/Controls/index.tsx 100% 88.88% 100% 100%
apps/evm/src/containers/Layout/NavBar/MenuItem/index.tsx 0% 0% 0% 0% 1-122
apps/evm/src/containers/Layout/NavBar/useMenuItems/index.tsx 0% 0% 0% 0% 1-121
apps/evm/src/containers/MarketTable/useColumns/index.tsx 88.42% 79.54% 66.66% 88.42% 150-151, 163-173, 209, 375, 379, 383-387, 406-424
apps/evm/src/pages/Landing/Hero/index.tsx 100% 0% 100% 100%
apps/evm/src/pages/Landing/Hero/HeroTabs/index.tsx 100% 86.66% 100% 100%
apps/evm/src/pages/Landing/Hero/HeroTabs/TabContent/index.tsx 100% 87.5% 100% 100%
apps/evm/src/pages/Landing/Hero/HeroTabs/TabContent/Earnings/index.tsx 100% 33.33% 100% 100%
apps/evm/src/pages/Landing/Hero/HeroTabs/TabContent/Earnings/BarChart/index.tsx 100% 100% 100% 100%
apps/evm/src/pages/Markets/Header/index.tsx 100% 0% 100% 100%
apps/evm/src/pages/Markets/Tabs/EMode/index.tsx 87.5% 71.42% 0% 87.5% 48-57, 87
apps/evm/src/utilities/index.ts 100% 100% 100% 100%
apps/evm/src/utilities/getBestDistributionApys/index.ts 96.15% 83.33% 100% 96.15% 2
Generated in workflow #13492 for commit 643d22c by the Vitest Coverage Report Action

Comment thread apps/evm/src/components/Dropdown/index.tsx Outdated
Comment thread apps/evm/src/utilities/getCombinedDistributionApys/index.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants