Add support for missing IL operations in DebuggerController::ComputeExprValue #802
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: xusheng6 <[email protected]>
|
|
Co-authored-by: xusheng6 <[email protected]>
Copilot
AI
changed the title
[WIP] DebuggerController::ComputeExprValue should support more operations
Add support for missing IL operations in DebuggerController::ComputeExprValue
Sep 8, 2025
Member
|
@copilot this leads to the following compilation error, please fix them: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
DebuggerController::ComputeExprValuemethod only supported the most common IL operations, causing expression evaluation to fail for less common but important operations like multiplication, division, function calls, and conditionals.This PR adds comprehensive support for 30 missing IL operations across all three IL levels (LLIL, MLIL, HLIL):
Added Operations
Arithmetic Operations (19 cases):
MUL,MULU_HI(unsigned high),MULS_HI(signed high)DIVS(signed),DIVU(unsigned)MODS(signed),MODU(unsigned)Bit Operations (2 cases):
ROL(rotate left),ROR(rotate right) - LLIL onlyControl Flow Operations (9 cases):
CALL,TAILCALL- returns destination addressIF- evaluates condition and returns 0/1Implementation Details
SignExtend()for proper negative number supportGetActualShift()helperExample Impact
Before this change, expressions containing these operations would fail:
After this change, all these operations are properly evaluated, significantly expanding the debugger's expression evaluation capabilities.
Fixes #639.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.