Only Allow Users to Select from Active Licenses#308
Merged
bencap merged 1 commit intorelease-2024.4.2from Nov 18, 2024
Merged
Conversation
During score set creation, we now only display active licenses to the user for selection. Because some score sets may have licenses selected which are no longer active, these licenses may be retained if they exist on a score set, but are un-selectable otherwise. Once a user updates a score set to get rid of such licenses, they will no longer be selectable. In addition, a new warning is displayed while editing such score sets so users are notified they are using a deprecated license.
jstone-dev
approved these changes
Nov 14, 2024
Collaborator
jstone-dev
left a comment
There was a problem hiding this comment.
See my comment on VariantEffect/mavedb-api#344. If you decide it's necessary to allow deprecated licenses on superseding score sets, then a UI change would be needed too. Otherwise, all good.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During score set creation, we now only display active licenses to the user for selection. Because some score sets may have licenses selected which are no longer active, these licenses may be retained if they exist on a score set, but are un-selectable otherwise. Once a user updates a score set to get rid of such licenses, they will no longer be selectable. In addition, a new warning is displayed while editing such score sets so users are notified they are using a deprecated license.
Coupled to VariantEffect/mavedb-api#344