additional options for controlling simID and the main output file#24
Merged
wzf-cn merged 2 commits intoV2Xgithub:dev-parallel-and-tracefilefrom Oct 6, 2023
Merged
Conversation
…n to manually specify simID
1. When writing the "mainout" file, using a "marker file" to indicate that the "mainout" file is writing now. In case of multiple processes write the file simultaneously. 2. If the outputs of different simulations are in one folder, the auto-set simIDs could not support "parfor". We may need another effective way to fix this promble.
Contributor
Author
|
hi wzf, Thank you for your changes, i think the lock file is a good idea. I don't have permissions to merge, but I am okay with the current fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi V2Xsim maintainers,
The purpose of this pull request is to add additional options to control whether the application writes the summary of results to
MainOut.xls, in addition to being able to control the name. There is also the option to manually specify thesimID- if not specified, it will use the old logic of auto incrementing (if printing to main out is disabled, defaults to simID 1)The motivation behind this is to enable parallelism such as running many simulations at once using
parfevalorparfor. If you want to callWiLabV2Xsim.min a parallel environment, the original behavior of trying to auto increment the ID will cause a race condition between the processes. In such cases, it is much more conducive to prepopulate a list of sim IDs depending on the research question being investigated, and have each simulation not write over each others' files because they might complete at different times.