-
Notifications
You must be signed in to change notification settings - Fork 26
Region tree renaming and fix #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CaelmBleidd
requested changes
Jun 26, 2023
CaelmBleidd
approved these changes
Jun 28, 2023
24 tasks
korifey
pushed a commit
that referenced
this pull request
Jul 12, 2023
petrukhinandrew
added a commit
to petrukhinandrew/usvm
that referenced
this pull request
Apr 28, 2025
petrukhinandrew
added a commit
to petrukhinandrew/usvm
that referenced
this pull request
May 5, 2025
Saloed
pushed a commit
that referenced
this pull request
Jun 2, 2025
petrukhinandrew
added a commit
to petrukhinandrew/usvm
that referenced
this pull request
Jun 19, 2025
petrukhinandrew
added a commit
to petrukhinandrew/usvm
that referenced
this pull request
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes issues with key deduplication by
RegionTreeand simplification found by @Saloed. Also, made renaming inRegionTreeto make it easier to understand.Details
Issue with key deduplication
Consider the following example:
It happens, because in case
keyFilterreturnstrue,localizeskips not only the top node, but also its subtree, which is incorrect in such case. Nowlocalizewith filtering maintains this correctly, but may leave some nodes even they satisfykeyFilter, which is OK for us.Issue with simplification
Consider the following example:
It happens, because guarded update nodes still remains in the memory region, though guards of some of them have evaluated to false. Fixed it in memory updates map functions.
Renaming
RegionTreeis actually a persistent event-storage with support of grouped reading and writing, where events live in specific regions. Thus, now its signature looks as followingclass RegionTree<Reg, Value>. IMO, it's much clearer.