This repository was archived by the owner on Jun 5, 2025. It is now read-only.
fix: move updating Web3Context into hook#34
Merged
kristiehuang merged 3 commits intowcf/basic-funcfrom Jun 16, 2022
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
kristiehuang
added a commit
that referenced
this pull request
Jun 17, 2022
* feat: set up ui elements for wallet connect * set up account avatar function * structure connect wallet modal * more ui updates for wc modal * wip provider utils * mm connection wip * linter * semi-working MM connection flow * Implement Metamask connection * minor alignment css * Add WIP WC functionality * Refactor useprovider fxn * Add link to help center for nowallet * Clean up useProvider * Fix WalletConnect; need window.Buffer polyfill * Fix WC connection * Add mainnet RPC URL fallback constant * Leave TODOs for readability * Leave TODOs for readability * Another todo * Update yarn.lock * Update .nvmrc for new @node/types * Better modal layout UI * Only use wallet if wallet is active * Update yarn.lock * Should only use our own flow iff provider & callbacks not given * fix: refactor wallet connection components (#33) * Refactor connect wallet into a separate component, and rename connect wallet callbacks * Rename callbacks * Fixes from PRs * Remove fallback JSON RPC URL logic; move to separate PR * Move web3 connection-related hooks into new folder * Rename and move connect web3-related hooks * fix: move updating Web3Context into hook (#34) * wip * Move context s.t. context is not exposed * Clean commit * Connect eagerly on mount * Minor css * Move components to Wallet * Rename dialog buttons to wallet name * Put network conditional back (fallback not implemented yet) * Add back disabled prop * Use e.preventDefault to determine opening our connection flow * Clean up unused code * nit * Clean comments * Don't deactivate other wallets before activating this one * Update yarn.lock
tinaszheng
added a commit
that referenced
this pull request
Feb 25, 2023
feat: add $0 network fee label for gouda swaps
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Want to move the update logic for Web3Context from
ConnectWalletDialoginto theuseActiveWeb3Reacthook so that we don't expose the full context object to the componentAdded a setter fxn, so Web3Context is now { web3, updateWeb3 }