Skip to content

fix: standardize SSA Auditorium locations #143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Deepak8858 wants to merge 2 commits into
base: develop
Choose a base branch
from
+6 −0
Open

fix: standardize SSA Auditorium locations #143

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b52eb48
fix: standardize SSA Auditorium locations (closes #142)
Adityasingh-upkgs Mar 22, 2026
238046b
Merge branch 'develop' into fix/issue-142-calendar-event
mikehquan19 Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions parser/cometCalendarParser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,12 @@ func ParseCometCalendar(inDir string, outDir string) {
// Get building and room
location := utils.ConvertFromInterface[string](event.Location)

// Standardize SSA Auditorium locations
if location != nil && (strings.Contains(*location, "SSA 13.330") || strings.Contains(*location, "SSA Auditorium")) {
standardized := "SSA Auditorium"
Copy link
Copy Markdown
Contributor

@KBui4 KBui4 Mar 31, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be standardized as "SSA 13.330".

Copy link
Copy Markdown
Contributor

@KBui4 KBui4 Mar 31, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the location really needed to be parsed to SSA Auditorium, then standardize after parsing the building and room, not before like here.

location = &standardized
}

// Regexp to match building abbreviations and room numbers
buildingRegexp := regexp.MustCompile(`[A-Z]{2,4}`)
roomRegexp := regexp.MustCompile(`([0-9]{1,2}\.[0-9]{3})([A-Z])?`)
Expand Down
Loading