Skip to content

Add linting and test checks#285

Open
krowvin wants to merge 3 commits into
mainfrom
269-add-linting-and-tests
Open

Add linting and test checks#285
krowvin wants to merge 3 commits into
mainfrom
269-add-linting-and-tests

Conversation

@krowvin
Copy link
Copy Markdown
Contributor

@krowvin krowvin commented Jun 4, 2026

I have noticed some of our other code fails to pass a linter. In the hopes of ensuring I don't accidentally leave unused imports, fail on var scope, and other things I wanted to enable a linter at least at the library level for future PRs.

Summary

  • Add pull request checks that run linting and Vitest. Hopefully prevent future lint errors.
  • Fix existing lint violations so the lint check can pass with --max-warnings 0.
  • Preserve existing component defaults while addressing props that were previously unused.

Closes #269

Verification

  • npm.cmd run lint
  • npm.cmd test -- --run (In the CI now)
  • npm.cmd run build-lib -- --emptyOutDir=false

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 4, 2026

Please set a versioning label of either major-bump, minor-bump, or patch-bump to the pull request.

@krowvin krowvin marked this pull request as ready for review June 4, 2026 16:01
@krowvin krowvin requested a review from willbreitkreutz June 4, 2026 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add Linting and Tests

1 participant