README: Add reference to OpenUI5 Sample App#1
Merged
Conversation
|
|
RandomByte
force-pushed
the
add-sample-app-reference
branch
from
March 29, 2018 13:14
8262fbe to
ddf3d10
Compare
matz3
approved these changes
Mar 29, 2018
RandomByte
added a commit
that referenced
this pull request
Jul 5, 2026
Both `ProjectBuilder.#build` and `ProjectBuilder.#validate` iterated
their project-context queue with `while (queue.length) { queue.shift() }`,
which is O(n^2) in the queue length for no reason — the queue is
constructed once from the pre-computed traversal and is not mutated
during iteration.
Switch both loops to `for (const projectBuildContext of queue)`. No
behaviour change; the shape now matches the actual access pattern.
Follow-up from BANNER_TODO item #1.
RandomByte
added a commit
that referenced
this pull request
Jul 6, 2026
Both `ProjectBuilder.#build` and `ProjectBuilder.#validate` iterated
their project-context queue with `while (queue.length) { queue.shift() }`,
which is O(n^2) in the queue length for no reason — the queue is
constructed once from the pre-computed traversal and is not mutated
during iteration.
Switch both loops to `for (const projectBuildContext of queue)`. No
behaviour change; the shape now matches the actual access pattern.
Follow-up from BANNER_TODO item #1.
RandomByte
added a commit
that referenced
this pull request
Jul 6, 2026
Both `ProjectBuilder.#build` and `ProjectBuilder.#validate` iterated
their project-context queue with `while (queue.length) { queue.shift() }`,
which is O(n^2) in the queue length for no reason — the queue is
constructed once from the pre-computed traversal and is not mutated
during iteration.
Switch both loops to `for (const projectBuildContext of queue)`. No
behaviour change; the shape now matches the actual access pattern.
Follow-up from BANNER_TODO item #1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.