feat: unified in-process worker (replace Docker containers)#5
Merged
TytaniumDev merged 2 commits intomainfrom Feb 7, 2026
Merged
feat: unified in-process worker (replace Docker containers)#5TytaniumDev merged 2 commits intomainfrom
TytaniumDev merged 2 commits intomainfrom
Conversation
Replace forge-sim and misc-runner Docker containers with direct child process execution and in-process log condensing/GCS upload. This eliminates Docker as a runtime dependency, adds dynamic parallelism based on system resources, and makes run_sim.sh configurable via environment variables for both container and local execution. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Owner
Author
Code reviewFound 1 issue:
local-worker/src/worker.ts (runForgeSim env) forge-simulation-engine/run_sim.sh (RUN_DECKS_DIR default and rm/cp) and L94-L101 Generated with Claude Code - If this code review was useful, please react with a thumbs up. Otherwise, react with a thumbs down. |
- run_sim.sh: symlink decks from DECKS_DIR to RUN_DECKS_DIR instead of copy - Orchestrator: GET /api/decks/:id/content (worker auth) for deck content - Orchestrator: store deckIds on job; GET /api/jobs/:id returns decks and/or deckIds for workers - Worker: DECK_CACHE_DIR, on-demand fetch on cache miss, processJob uses cache when job has deckIds - Fix orchestrator-service/.gitignore: /jobs/ so app/api/jobs routes are not ignored Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run_sim.shconfigurable via environment variables (FORGE_PATH,DECKS_DIR,LOGS_DIR,RUN_DECKS_DIR) so it works in both standalone container and local/unified execution modescondenser.ts(log parsing/condensing),gcs-client.ts(GCS upload),types.ts(shared types)unified-worker/) with Dockerfile and docker-compose for containerized deploymentTest plan
FORGE_PATHpointed at a local Forge installation and verify simulations executecondensed.jsonandanalyze-payload.jsonrun_sim.shstill works in the standalone forge-sim container🤖 Generated with Claude Code