Improved validation and more#90
Merged
Merged
Conversation
…ed a few wrong generics, updated documentation
…all properties of DiagnosticInfo for Langium in Typir-Langium, test case with code action
insafuhrmann
approved these changes
Aug 15, 2025
Member
There was a problem hiding this comment.
I think this is a great contribution for more customisation and type safety. It is also very helpful to be able to use al properties from DiagnosticInfo from Langium and enables the user to register code actions. Thank you @JohannesMeierSE. I have almost no detail remarks (you can even ignore the one I have added somewhere about a missing word, it is not especially important).
| export type Severity = 'error' | 'warning' | 'info' | 'hint'; | ||
|
|
||
| export interface ValidationMessageDetails { | ||
| export interface ValidationMessageDetails { // Using this type only the TypirSpecifics (and not directly in the ValidationProblem below) enables to customize its properties. |
Member
There was a problem hiding this comment.
only "in" the TypirSpecifics?
This was referenced Aug 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main contributions of this PR
<LanguageType>generic is replaced by<Specifics extends TypirSpecifics>in order to provide more customizations in a extendable wayDiagnosticInfofor validation issues (with a test case for a code action in LOX)Hints: