Preserve original exception identity through train pipeline#16
Merged
Conversation
Stop mutating exception messages via reflection — store TrainExceptionData in Exception.Data instead. Use ExceptionDispatchInfo in ResolveOrThrow to preserve original stack traces. Callers outside Trax now see the original exception type, message, and stack trace.
|
This PR is included in version 1.4.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
RailwayJunction— storeTrainExceptionDatainException.Datainstead, preserving the original message for callers outside TraxExceptionDispatchInfoinResolveOrThrowto preserve original stack traces through the Monad pipelineStackTracefield toTrainExceptionDatato capture the original throw site at catch timeTest plan
TrainExceptionDataTests— StackTrace serialization round-trip, null handling, backwards compatJunctionCancellationTests— original message preserved, Exception.Data attached, stack trace capturedStackTracePreservationTests— end-to-end through Train.Run/RunEither verifying original stack trace, message, and typeJsonEscapingTests— rewritten to verify original message preserved + structured data in Exception.Data