[docs] session retrospective: three meta-lessons captured#84
Merged
Conversation
Three observations from the recent session that aren't already in the structured surfaces, captured via the learn-from-mistakes flow. Each lands in its existing topic note. automation.md — memory captures rationale; hooks enforce. The pre-PR checklist memory landed earlier was followed by a lint failure shipped to CI within the hour. Same gap closed reliably by the PreToolUse hook installed soon after. For 'always do X before Y' patterns, prefer the hook; the memory documents why. ci.md — frame CI/perf projections as ranges, not single numbers. PR #72's 155s wall-time projection vs 242s actual cost an investigation round because the projection's setup-go-cache amortization assumption was unverified. Either verify assumptions empirically before publishing the number or frame as a range. review-patterns.md — self-rate work, then write criteria for the next grade up. Forces articulation of measurable improvements rather than free-form 'anything else?'. PR #76's B+ → A → A+ came from two iterations of this pattern. make doc-check clean locally. Signed-off-by: Tri Lam <trilamsr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three observations from the recent session that didn't fit the structured surfaces (already used for the load-bearing AGENTS.md entries in PR #81 and the agent-internal notes in PR #82). Each captured via the
learn-from-mistakesflow and lands in its existing topic note..claude/notes/automation.md— Memory captures rationale; hooks enforce. The pre-PR checklist personal memory landed mid-session was followed by a lint failure shipped to CI within the hour. The same gap closed reliably by thePreToolUsehook installed shortly after. For any "always do X before Y" pattern, prefer the hook; the memory documents why the hook exists.docs/notes/ci.md— Frame CI / perf projections as ranges, not single numbers. PR #72's 155s wall-time projection vs 242s actual cost an investigation round (later landed in PR #77) because the projection's setup-go-cache amortization assumption was unverified. Either verify assumptions empirically before publishing the number, or frame as a range..claude/notes/review-patterns.md— Self-rate work, then write criteria for the next grade up. Forces articulation of measurable improvements rather than free-form "anything else?". PR #76's B+ → A → A+ came from two iterations of this exact pattern; each iteration closed real structural gaps.A fourth lesson — "fix existing tools before proposing new ones" — was captured to personal memory (no PR, lives in
~/.claude/projects/.../memory/), not the repo, because it's a judgment heuristic about my own decision-making rather than a repo-resident convention.Test plan
make doc-checkclean (banned-phrase lint, link resolution, all gates).learn-from-mistakesformat check: banned vocabulary absent, no first-person AI phrasing, no AI attribution, all three entries carryAnchor:lines pointing at concrete PRs.doc-check+pr-lint.Rollback
Each entry is a self-contained
### title+ body +Anchor:block at the top of its file. No dependents elsewhere; reverting is a single Edit per file.