Skip to content

[ci] selftelemetry: relax degraded-counter regex to accept any positive value #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trilamsr merged 1 commit into from
May 19, 2026
Merged

[ci] selftelemetry: relax degraded-counter regex to accept any positive value #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions internal/selftelemetry/impl_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,9 +128,14 @@ func TestReceiver_SetDegraded(t *testing.T) {

body := scrape(t, url)
require.Contains(t, body, "tracecore_receiver_degraded_seconds_total")
// Value must be >0 (>= ~0.05s).
// Value must be >0. The intent is "advanced past zero"; the
// fractional part must contain at least one non-zero digit. No
// upper bound — CI runners under contention can extend the
// observed window well past 50ms (a slow runner saw 0.126s on
// PR #76's rerun and failed against the prior `0\.0[0-9]+`
// upper-bound shape).
require.Regexp(t,
`tracecore_receiver_degraded_seconds_total\{[^}]*component_id="clockreceiver/TestReceiver_SetDegraded"[^}]*\}\s+0\.0[0-9]+`,
`tracecore_receiver_degraded_seconds_total\{[^}]*component_id="clockreceiver/TestReceiver_SetDegraded"[^}]*\}\s+\d+\.[0-9]*[1-9]`,
body, "degraded counter advanced past 0")

recv.SetDegraded(false)
Expand Down
Loading