Skip to content

[ci] deflake journald mock test + warn when shellcheck missing locally #68

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trilamsr merged 1 commit into from
May 19, 2026
Merged

[ci] deflake journald mock test + warn when shellcheck missing locally #68

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,11 @@ register-lint: ## Verify `func Register*` symbols live only under components/**
@scripts/register-lint.sh

actionlint: ## Lint GitHub Actions workflow files (syntax + embedded shellcheck for run: blocks).
@if ! command -v shellcheck >/dev/null 2>&1; then \
echo "WARNING: shellcheck not on PATH; actionlint will skip run-block shellcheck."; \
echo " macOS: brew install shellcheck"; \
echo " Linux: apt-get install shellcheck"; \
fi
go tool actionlint

no-autoupdate-check: ## Enforce RFC-0008: cmd/, components/, internal/, pkg/ contain no in-binary auto-update mechanism. Also runs the gate's own regression test against fixtures.
Expand Down
4 changes: 2 additions & 2 deletions components/receivers/kernelevents/journald_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,8 +36,8 @@ func TestJournaldSource_StreamsMockOutput(t *testing.T) {
case rec := <-out:
require.Equal(t, 3, rec.priority, "Xid is err-level")
require.Contains(t, rec.body, "Xid (PCI:0000:65:00.0): 79")
case <-time.After(2 * time.Second):
t.Fatal("no record from mock journalctl within 2s")
case <-time.After(5 * time.Second):
t.Fatal("no record from mock journalctl within 5s")
}
}

Expand Down
Loading