chore: relocate internal/integration + retire stale Make/canary#526
Merged
Conversation
Signed-off-by: Tri Lam <tree@lumalabs.ai>
Signed-off-by: Tri Lam <tree@lumalabs.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three repo-hygiene micro-cleanups bundled in one PR (no behaviour change for operators).
Task 1 — relocate
internal/integration/ocb_scrape_test.go→bench/e2e/The one-file
internal/integration/package held a single OCB-binary regressiontest (
TestOCBScrape_UpstreamMetricVocabulary) that asserts upstreamotelcol_*metric vocabulary survives OCB version bumps. It had no Go importers — only
prose links in two migration docs and one history doc.
bench/e2e/already hosts the integrated end-to-end Go tests(
budget_assertion_test.go,steady_state_linux_test.go) with the sameskip-when-
_build/tracecore-missing posture and the same package scope.Merged the test in, dropped the one-file
internal/dir entirely (no othercontents), updated the godoc, fixed the
runtime.Callerrepo-root walk-upcomment, and re-pointed the
.golangci.ymlG204/G107 gosec exclusion + twodocs/migration/doc links.docs/history/v1-rc1-test-audit.mdis exemptfrom
doc-checkas historical record.Task 2 — delete
make build-tagsThe
build-tagsMakefile target was verbatimgo vet ./...— identicalto the
vettarget already in:CHECK_DEPS(pre-commit, viamake/check.mk)CI_FULL_DEPS(full CI, viamake/ci-full.mk)make verifytransitively viacheckThe "future build-tag-gated paths" rationale never materialized post-
dcgmretirement (PR-F.1). The lane added zero signal anywhere.
Deleted:
Makefilebuild-tagsfromPHONY_TARGETS(make/phony.mk)build-tagsfromVERIFY_DEPS(make/verify.mk)build-tagsfromCI_FULL_DEPS(make/ci-full.mk).githooks/pre-push.github/workflows/ci.ymlassert_ran/assert_skippedlines inscripts/pre-push-test.shdocs/notes/ci.mdanddocs/MILESTONES.md§374Historical references in
CHANGELOG.md,docs/followups/M8.md,docs/v1-rc1-governance-gaps.md, and DCGM/RCCL milestone rubrics(
docs/MILESTONES.md§304/§329) describe past state and stay as-is.Task 3 — delete
bench/canary/kueue-metric-surface.{sh,baseline}Draft canary tooling for the
components/receivers/kueue/receiver thatwas deleted at v0.1.0 per RFC-0013 §7 (replaced by
prometheusreceiverrecipe). The DRAFT was never wired into any CI workflow; the receiver
it gated is gone. The
bench/canary/directory had no other contents.Updated
docs/research/m16-kueue-production-followups.mdP8 to "WITHDRAWN"with a restore-from-git-history note if the recipe ever needs a smoke gate.
Decisions log
bench/e2e/(packagee2e)bench/install/(shell-only);tests/integration/(does not exist)vet)vetDiff stat
16 files changed, 36 insertions(+), 243 deletions(-)— net −207 LoC.Test plan
make check(lint + vet + tidy + mod-verify + attribute-namespace) — cleanmake lint— 0 issues (root +module/)make doc-check— clean (RFC status, alert parity, SLO promtool, chart-appVersion, 1110 markdown links, 217 anchors)go vet ./...— cleango test ./...— all packages passbash scripts/pre-push-test.sh— ALL PASS (build-tags assertions removed).githooks/pre-pushran clean on push