chore(followups): stub M13 + trim M8 DCGM section#511
Merged
Conversation
Signed-off-by: Tri Lam <tree@lumalabs.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wave 2 PR-B per Lane H followups-dir recon. Two doc-only edits trim
~643 net LoC of stale carry-forward backlog from
docs/followups/:M13.mdstubbed (446 → 13 lines, -433). Pyspy receiver workis DEFERRED to v0.4.0+ per #222
(
external-clocklabel) and RFC-0009. The receiver still ships incomponents/receivers/pyspy/, but the carry-forward queue ispaused. File kept in place as a load-bearing marker — sibling
issue [rc1-prep] Track pyspy-delete re-evaluation preconditions (blocked on #222 / RFC-0013 PR-M) #335 tracks re-evaluation preconditions.
M8.mdDCGM section removed (318 → 108 lines, -210). RFC-0013§7 STRIKE'd the in-tree DCGM receiver in favor of
dcgm-exporterprometheusreceiverin the bundled recipe; the cgo stub nevershipped real code. All DCGM-specific bullets (
pkg/dcgm,client_cgo,kindWatch/kindMIG, AST resolver, libdcgm SIGSEGVsubprocess,
dcgm_infojoin-target,pkg/vendorsdk-template,perf-gate, HARDWARE-TESTING shipped marker) are gone. Surviving
items:
tracecore debug dump[AUDIT],validate --explainclosed marker, prometheus-alerts federation labels
[KEEP],grafana-dashboard per receiver
[KEEP], OTelhw.*semconvupstream PR
[UPSTREAM], build-tags CI closed marker, M8↔M9Option-pattern consistency review
[AUDIT].M3.mdandM15.mdstrikethrough sweep was a no-op —rg '^~~'returned zero matches in both files (the spec's "if 5+ matches,
collapse" predicate did not fire).
Pre-flight grep
rg DCGM docs/cross-confirmed no inbound anchor refs into thedeleted M8 bullets — DCGM mentions in
MILESTONES.md,v1-rc1-cut-criteria.md,FOLLOWUPS.md, etc. are about the milestonedefinitions and the RFC-0013 strike table, not specific M8 line
anchors.
M11.mdalready documents that DCGM lives under M8 and is[STRIKE]per RFC-0013 §7 — that pointer remains valid.LoC delta
Conflict check
Different files than Wave 2 PR-A (
docs/v1-rc1-*), Lane F(
module/**/*.go), and #504/#506. No overlap with any in-flight PRtouching
docs/followups/.Test plan
git diff --statconfirms 2 files, 58 insertions, 701 deletionswc -l docs/followups/M13.md= 13 lines (target ≤25)grep -ic dcgm docs/followups/M8.md= 6 (down from 32)