Skip to content

ci(bench): cover all 6 detectors in % delta gate (#302) #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trilamsr merged 1 commit into from
Jun 2, 2026
Merged

ci(bench): cover all 6 detectors in % delta gate (#302) #483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 56 additions & 0 deletions bench/detectors/testdata/bench-baseline.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
goos: darwin
goarch: arm64
pkg: github.com/tracecoreai/tracecore/bench/detectors
cpu: Apple M1 Max
BenchmarkXidCorrelationDetector-10 171 4874819 ns/op 596889 B/op 1928 allocs/op
BenchmarkXidCorrelationDetector-10 122 6060666 ns/op 596830 B/op 1928 allocs/op
BenchmarkXidCorrelationDetector-10 100 5639720 ns/op 596819 B/op 1928 allocs/op
BenchmarkXidCorrelationDetector-10 172 6294659 ns/op 596828 B/op 1928 allocs/op
BenchmarkXidCorrelationDetector-10 100 6612498 ns/op 596814 B/op 1928 allocs/op
BenchmarkXidCorrelationDetector-10 150 3986868 ns/op 596795 B/op 1928 allocs/op
BenchmarkXidCorrelationDetector-10 134 5221490 ns/op 596803 B/op 1928 allocs/op
BenchmarkXidCorrelationDetector-10 100 5352039 ns/op 596820 B/op 1928 allocs/op
BenchmarkXidCorrelationDetector-10 144 6068193 ns/op 596804 B/op 1928 allocs/op
BenchmarkXidCorrelationDetector-10 100 7114691 ns/op 596803 B/op 1928 allocs/op
BenchmarkHBMECCDetector-10 223 4865933 ns/op 340581 B/op 1301 allocs/op
BenchmarkHBMECCDetector-10 296 1928148 ns/op 340509 B/op 1301 allocs/op
BenchmarkHBMECCDetector-10 349 2310156 ns/op 340539 B/op 1301 allocs/op
BenchmarkHBMECCDetector-10 266 2432362 ns/op 340562 B/op 1301 allocs/op
BenchmarkHBMECCDetector-10 332 2428301 ns/op 340504 B/op 1301 allocs/op
BenchmarkHBMECCDetector-10 367 3585360 ns/op 340542 B/op 1301 allocs/op
BenchmarkHBMECCDetector-10 310 1821341 ns/op 340537 B/op 1301 allocs/op
BenchmarkHBMECCDetector-10 361 3159744 ns/op 340519 B/op 1301 allocs/op
BenchmarkHBMECCDetector-10 182 3162990 ns/op 340618 B/op 1301 allocs/op
BenchmarkHBMECCDetector-10 700 1985921 ns/op 340578 B/op 1301 allocs/op
BenchmarkNCCLHangDetector-10 242 3448374 ns/op 537958 B/op 1743 allocs/op
BenchmarkNCCLHangDetector-10 186 3115292 ns/op 537967 B/op 1743 allocs/op
BenchmarkNCCLHangDetector-10 291 2562511 ns/op 537965 B/op 1743 allocs/op
BenchmarkNCCLHangDetector-10 210 3610532 ns/op 537968 B/op 1743 allocs/op
BenchmarkNCCLHangDetector-10 100 5423202 ns/op 537968 B/op 1743 allocs/op
BenchmarkNCCLHangDetector-10 117 5746886 ns/op 537992 B/op 1743 allocs/op
BenchmarkNCCLHangDetector-10 241 4125885 ns/op 537958 B/op 1743 allocs/op
BenchmarkNCCLHangDetector-10 231 3910041 ns/op 537967 B/op 1743 allocs/op
BenchmarkNCCLHangDetector-10 164 4025848 ns/op 537964 B/op 1743 allocs/op
BenchmarkNCCLHangDetector-10 282 3446109 ns/op 537962 B/op 1743 allocs/op
BenchmarkThermalThrottleDetector-10 322 1588800 ns/op 204100 B/op 780 allocs/op
BenchmarkThermalThrottleDetector-10 199 3820089 ns/op 204106 B/op 780 allocs/op
BenchmarkThermalThrottleDetector-10 636 1678016 ns/op 204101 B/op 780 allocs/op
BenchmarkThermalThrottleDetector-10 381 1717911 ns/op 204098 B/op 780 allocs/op
BenchmarkThermalThrottleDetector-10 864 802713 ns/op 204098 B/op 780 allocs/op
BenchmarkThermalThrottleDetector-10 820 1503855 ns/op 204101 B/op 780 allocs/op
BenchmarkThermalThrottleDetector-10 942 1507444 ns/op 204098 B/op 780 allocs/op
BenchmarkThermalThrottleDetector-10 583 1540358 ns/op 204100 B/op 780 allocs/op
BenchmarkThermalThrottleDetector-10 388 1597402 ns/op 204103 B/op 780 allocs/op
BenchmarkThermalThrottleDetector-10 824 1051058 ns/op 204100 B/op 780 allocs/op
BenchmarkPCIeAERDetector-10 541 1273900 ns/op 208887 B/op 524 allocs/op
BenchmarkPCIeAERDetector-10 781 667710 ns/op 208883 B/op 524 allocs/op
BenchmarkPCIeAERDetector-10 529 945375 ns/op 208898 B/op 524 allocs/op
BenchmarkPCIeAERDetector-10 802 643069 ns/op 208883 B/op 524 allocs/op
BenchmarkPCIeAERDetector-10 676 1432330 ns/op 208885 B/op 524 allocs/op
BenchmarkPCIeAERDetector-10 403 1449597 ns/op 208889 B/op 524 allocs/op
BenchmarkPCIeAERDetector-10 1046 555794 ns/op 208882 B/op 524 allocs/op
BenchmarkPCIeAERDetector-10 819 924235 ns/op 208881 B/op 524 allocs/op
BenchmarkPCIeAERDetector-10 1009 786439 ns/op 208881 B/op 524 allocs/op
BenchmarkPCIeAERDetector-10 685 1100230 ns/op 208883 B/op 524 allocs/op
PASS
ok github.com/tracecoreai/tracecore/bench/detectors 77.021s
9 changes: 9 additions & 0 deletions scripts/bench-registry.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,17 @@
# HeapAlloc) stay advisory and OUT of this registry.

bench_entries=(
# PodEvictedDetector is gated via module/pkg/patterns/pod_evicted_bench_test.go
# (BenchmarkPodEvictedDetector_1kEventWindow); the other five detectors live
# under ./bench/detectors/ and are gated through the entry below. Together
# this gives every detector both the absolute allocs/event ceiling
# (allocs_gate, below) AND the % delta gate run via scripts/bench-check.sh.
"module/pkg/patterns|^BenchmarkPodEvictedDetector"
"components/receivers/pyspy|^Benchmark(ParseDump|StackID)\$"
# Single regex / single `go test` invocation keeps the gate fast
# (~5s incremental vs ~30s if we split into 5 entries). Benchmarks
# are sourced from bench/detectors/detectors_bench_test.go.
"bench/detectors|^Benchmark(XidCorrelation|HBMECC|NCCLHang|ThermalThrottle|PCIeAER)Detector\$"
)

# allocs_gate — per-detector absolute alloc ceilings (issue #302). Each
Expand Down