docs(principles): lift §1 to lint (5/16 → 6/16) (#323)#407
Merged
Conversation
§1 (Trust under load) already covered by gosec + govet + errcheck. Update the mapping table row to reflect that and bump the O7 KPI counter from 5 to 6. Docs-only edit; no .golangci.yml change required (gosec + govet + errcheck were already in linters.enable). The mapping table is the audit source-of-truth per the table's intro. Partial-closes #323 — §6 depguard rule + principles-to-enforcement table sweep deferred (table sweep would be a separate audit pass; depguard rule for §6 needs allowlist enumeration). Signed-off-by: Tri Lam <tri@maydow.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
§1 (Trust under load) was already covered by
gosec+govet+errcheckin.golangci.yml.linters.enable— the PRINCIPLES.md table just hadn't been updated to reflect it. Two-line edit promotes §1 frompartial lint→lintand bumps the O7 KPI counter from 5/16 → 6/16, hitting the rc1 target.Root cause
PR #357 (governance) enabled gosec + govet at file level but the mapping-table row for §1 was not updated. The KPI counter (5) was authored before that PR landed.
What this does NOT do (deferred from #323)
pkg/...paths — defer; requires enumerating ~10 paths into the allowlist; separate small PR.This PR is intentionally surgical: 2 lines, no
.golangci.ymlchange, no behavior change. The lint rules were already running; this corrects the documentation.Test plan
make lint— 0 issuesgo vet ./...— passattribute-namespace-check— greenPartial-closes #323 (§1 row only — depguard for §6 deferred).