chore(module): trim stale PR-I genesis-tag rationale (#381)#390
Closed
trilamsr wants to merge 1 commit into
Closed
chore(module): trim stale PR-I genesis-tag rationale (#381)#390trilamsr wants to merge 1 commit into
trilamsr wants to merge 1 commit into
Conversation
PR-I.1a/1b/2 all landed; the genesis-tag proxy-resolution rationale is a historical artifact. Keep package doc only. Closes #381. Signed-off-by: Tri Lam <tri@maydow.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
module/doc.gocarries an 8-line rationale for themodule/v0.0.1genesis tag and PR-I.1a/PR-I.1b/PR-I.2 sequencing. All three PRs landed long ago; the module is alive, well, and resolvable through the Go module proxy.Root cause
The doc.go was authored when the module-split was an active multi-PR sequence; the proxy-resolution rationale was load-bearing for reviewers verifying the genesis tag cut. Both conditions are now historical. Reading it cold today produces noise, not signal.
Fix
Trim to a 2-line package doc.
package moduledeclaration retained — Go module proxy requirement.Test plan
go list -m github.com/tracecoreai/tracecore/module→ resolvesCloses #381.