docs(rfc-0013): amend §migration — PR-I/K sub-slicing + PR-B2 gate#199
Merged
Conversation
Four amendments per scope-review findings, pre-staged before PR-I.1/K/M code work begins to avoid mid-flight escalations: 1. §6/§7 sweep miss from #181 rescope: remove surviving `tracecoreai/tracecore-components` external-repo references across 6 companion docs (`docs/getting-started.md`, `docs/followups/M11.md`, `docs/followups/M19.md`, `docs/FOLLOWUPS.md`, `docs/rfcs/0003-pipeline-runtime-and-component-contract.md`, `AGENTS.md`). Re-point at `github.com/tracecoreai/tracecore/module` in-repo submodule per RFC-0013 §6. 2. §7 nonexistent workflow entries: collapse `pyspy-integration.yml`, `python-publish.yml`, `kernelevents-integration.yml` deletion rows into one "already removed pre-RFC" row. `component-bug-dcgm.yml` removed pre-RFC; only `component-bug-kernelevents.yml` remains for PR-K. Also clean §4 v0.3.0 row + PR-M slug for consistency. 3. §migration PR-K sub-slice: split into K.1 (sever patterns lib from k8sevents via `internal/synthesis/patterns/model.go`), K.2 (delete 4 receivers + migrate ~86 fixtures + delete `tools/failure-inject/xidgen/`), K.3 (chart cleanup + values-key deprecation cycle). 4. §migration PR-I sub-slice + PR-B2 promotion: PR-B2 reframed as hard gate for PR-I.1b (port nccl_fr off `internal/{pipeline,consumer,runtime/lifecycle}` to upstream); split PR-I.1 into I.1a (`module/go.mod` + `go.work` scaffolding, tag `module/v0.0.1` genesis) and I.1b (`git mv` + package rename). PR-I.2 tags `module/v0.1.0` (first version pinned in `builder-config.yaml` for v0.2.0). PR-J marked landed (#195). Slug-collision note added: merged commit #188 (`feat(pivot): PR-B2 — port dcgm off internal selftel + lifecycle`) reused the PR-B2 label for PR-B1-shape dcgm work; that does not satisfy the canonical PR-B2 slot defined here. Docs-only. No code paths touched. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Tri Lam <tri@maydow.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Four amendments to
docs/rfcs/0013-distro-first-pivot.md(plus a one-line sweep across 6 companion docs) per the scope-review findings staged before PR-I.1 / PR-K / PR-M code work begins. Pre-stages each decision in the RFC so the autonomous code PRs don't escalate mid-flight.Root cause
#181 (RFC-0013 PR-I in-repo submodule rescope) was incomplete:
tracecoreai/tracecore-componentsrepo.component-bug-dcgm.yml) that was already removed pre-RFC.internal/synthesis/patterns/k8sevents dep break, which is on PR-I.2's critical path.module/go.modscaffolding with thegit mv+ package rename, blocking PR-I.1a from landing without PR-B2 even though the scaffolding step has no nccl_fr dep.Mid-flight discovery during merge cycle: merged commit #188 (
feat(pivot): PR-B2 — port dcgm off internal selftel + lifecycle) reused thePR-B2slug for a PR-B1-shape dcgm port (which is moot since dcgm is deleted entirely in PR-F), creating a naming collision against the canonical PR-B2 defined in the RFC — the nccl_frinternal/{pipeline,consumer,runtime/lifecycle}→ upstream port that hard-gates the PR-I.1bgit mv.Amendments
tracecoreai/tracecore-componentsexternal-repo references acrossdocs/getting-started.md,docs/followups/M11.md,docs/followups/M19.md,docs/FOLLOWUPS.md,docs/rfcs/0003-pipeline-runtime-and-component-contract.md,AGENTS.md. All re-pointed atgithub.com/tracecoreai/tracecore/moduleper RFC-0013 §6. Verified zero surviving stale refs.pyspy-integration.yml,python-publish.yml,kernelevents-integration.ymldeletion rows into one row marked "already removed pre-RFC".component-bug-dcgm.ymlalso already removed. Onlycomponent-bug-kernelevents.ymlsurvives for PR-K. §4 v0.3.0 row + PR-M slug cleaned for consistency.internal/synthesis/patterns/fromcomponents/receivers/k8seventsvia local model types ininternal/synthesis/patterns/model.go. No deletions. Unblocks PR-I.2.components/receivers/{clockreceiver,kernelevents,k8sevents,containerstdout}+ migrate ~86 test fixtures + deletetools/failure-inject/xidgen/+ keeptools/failure-inject/ncclhang/.containerstdout-on-values.yamlto filelog+container-stanza, deletecontainerstdout-rbac.yaml, delete.github/ISSUE_TEMPLATE/component-bug-kernelevents.yml, shipNOTES.txtdeprecation + values-key removal.components/receivers/nccl_froffinternal/{pipeline,consumer,runtime/lifecycle}to upstreamgo.opentelemetry.io/collector/{component,receiver,consumer,pipeline}. Slug-collision note added re: merged feat(pivot): PR-B2 — port dcgm off internal selftel + lifecycle #188.module/go.mod+ rootgo.work+builder-config.yamlreplaces:skeleton. No file movement. Tagmodule/v0.0.1(genesis tag, validates the tagging contract).git mv components/receivers/nccl_fr → module/receiver/ncclfrreceiver+git mv pkg/nccl/fr_parser → module/pkg/nccl/fr_parser+ rename Go packagenccl_fr→ncclfrreceiver+ update all importers. Hard-gated on PR-B2. No new tag; next bump ismodule/v0.1.0at PR-I.2.rankjoinprocessor+patterndetectorprocessornet-new. Hard-gated on PR-K.1. Tagmodule/v0.1.0(first version pinned inbuilder-config.yamlfor v0.2.0).Also: PR-J marked
(landed, #195)with note that recipe docs landed but chart-values compat map follows in PR-K.3.Adversarial review (5 lenses, inline)
grep -rn "tracecoreai/tracecore-components" docs/ AGENTS.md README.mdreturns zero hits post-amendment.docs/migration/v0.1-to-v0.2.mdreferences#migration--rolloutand#3-customer-stable-telemetry-contracts; both anchors preserved (§ headers unchanged).make doc-checkconfirms 526 markdown links resolve.Test plan
make doc-check— 526 markdown links resolve, 0 stale refs, banned-phrase lint clean, alert-check + chart-appversion gates green.