chore(pivot): wave-1 self-review fixes — delete archive + drift sweep#175
Merged
Conversation
Self-review of PR #174 found drift between docs and the new release.yml, plus a half-measure "archive" that violates the no-bloat directive. Fixes: - DELETE `.github/workflows/archived/release.yml.legacy`. Archive is a half-measure — git history is the archive. Removes the empty `.github/workflows/archived/` directory too. - DROP `workflow_dispatch` trigger from release.yml. Tag-push is the only legitimate release path; manual dispatch was a bypass scenario that complicated signing identity verification (cosign verify-blob hardcodes `--certificate-github-workflow-trigger 'push'`). - FIX `docs/reproducibility.md` workflow path drift: 4 refs to non-existent `goreleaser.yml` → correct `release.yml`. - FIX `.goreleaser.yaml` comment: removed reference to non-existent "reproducible flag" — determinism comes from `mod_timestamp` (already in the config). - UPDATE prose refs in CHANGELOG.md, MILESTONES.md, docs/notes/ci.md, release.yml header — "archived under .github/workflows/archived/" → "preserved in git history". Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Tri Lam <tri@maydow.com>
trilamsr
pushed a commit
that referenced
this pull request
May 31, 2026
TestPipeline_E2E_LineEmittedWithAttribution is timing-sensitive under -race (informer + healthLoop poll cadence). Failed twice in CI on unrelated PRs (#175, #176). Receiver is slated for v0.2.0 deletion per RFC-0013 §7; M19 join contract re-homes to processor/rankjoinprocessor against upstream filelogreceiver + k8sobjectsreceiver (tracked in issue #163). Per no-bloat: investing in a fix for a dying receiver wrong shape. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: Tri Lam <tri@maydow.com>
3 tasks
trilamsr
added a commit
that referenced
this pull request
May 31, 2026
…ft (#178) ## What this PR does Sweeps three drift sites that surfaced after wave-2 PRs landed: - `CHANGELOG.md`: replaces stale "Pivot wave 1 landed [...] PR-A is next" prose (written before PR-A actually merged in #171) with the full landed history through #176. Adds two paragraphs documenting the PR-E blocker (upstream `telemetrygeneratorreceiver` doesn't exist) and the PR-F deferral (chart default pipeline hardwires the to-be-deleted receivers; deletion happens together with the v0.2.0 recipe migration in PR-K to avoid an interim chart break). - `bench/install/tracecore-values.yaml`: the PR-E status note pointed at "PR-F deletion" as the rewire trigger. Corrected to PR-K since PR-F is deferred. - `.goreleaser.yaml`: header still referenced the deleted `.github/workflows/archived/release.yml.legacy` path. Replaced with "preserved in git history" (matches what other docs already say after PR #175). ## Root cause Wave-2 PRs landed faster than the in-tree status prose could keep up. The CHANGELOG paragraph in particular was authored mid-pivot before PR-A merged, and was never refreshed. Caught in a post-merge sweep. ## Release notes ```release-notes NONE ``` ## Test plan - [x] `make verify` runs and passes - [x] `grep -r "workflows/archived" .` returns only the (untouched) RFC reference, which is binding-doc and out of scope for this sweep - [x] CHANGELOG and bench values still parse as YAML / markdown Signed-off-by: Tri Lam <tri@maydow.com> Co-authored-by: Tri Lam <tri@maydow.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Cleans up drift from PR #174 surfaced by self-review, plus deletes the half-measure "archive" per the no-bloat directive.
Deletions
.github/workflows/archived/release.yml.legacy(700+ lines) — git history is the archive. Removed the empty.github/workflows/archived/directory too.workflow_dispatchtrigger fromrelease.yml— tag-push is the only legitimate release path; manual dispatch was a bypass scenario that complicated signing identity verification (cosign verify-blobhardcodes--certificate-github-workflow-trigger 'push').Drift fixes
docs/reproducibility.md— 4 refs to the non-existentgoreleaser.ymlcorrected to the actual workflow namerelease.yml..goreleaser.yamlcomment — removed reference to a non-existent "reproducible flag"; determinism comes frommod_timestamp(already in the config).CHANGELOG.md,MILESTONES.md,docs/notes/ci.md,release.ymlheader — prose updated from "archived under .github/workflows/archived/" → "preserved in git history".Root cause
PR #174 self-review identified five findings; this PR fixes all of them in one pass instead of accumulating a TODO list. Two patterns surfaced:
release.yml) landing, leaving four cross-references that point at a workflow that doesn't exist.Release notes
Test plan
make verifyruns and passesmake actionlintpasses (release.yml without workflow_dispatch is still valid)grep -r "goreleaser.yml" docs/returns no hitsgrep -r "workflows/archived" .returns only the (untouched) RFC reference at docs/rfcs/0013-distro-first-pivot.md line 235 — that one stays unchanged here per RFC binding-doc policy; can be cleaned in a future RFC patch