[m14] kineto profiler receiver: RFC-0012 + pkg/kineto/ parser + receiver + bench scaffold#107
Closed
trilamsr wants to merge 15 commits into
Closed
[m14] kineto profiler receiver: RFC-0012 + pkg/kineto/ parser + receiver + bench scaffold#107trilamsr wants to merge 15 commits into
trilamsr wants to merge 15 commits into
Conversation
Signed-off-by: Tri Lam <trilamsr@gmail.com>
…nism, fr_trace disclaimer Signed-off-by: Tri Lam <trilamsr@gmail.com>
…els (Tasks 3-4) Signed-off-by: Tri Lam <trilamsr@gmail.com>
…maxevents/golden-stub) (Tasks 5-8, 10-stub) Signed-off-by: Tri Lam <trilamsr@gmail.com>
…ip tests (Task 9) Signed-off-by: Tri Lam <trilamsr@gmail.com>
…nerate-fixtures CI gate (Task 10) Signed-off-by: Tri Lam <trilamsr@gmail.com>
Signed-off-by: Tri Lam <trilamsr@gmail.com>
Signed-off-by: Tri Lam <trilamsr@gmail.com>
…ocyclo (Task 13) Signed-off-by: Tri Lam <trilamsr@gmail.com>
…gest, factory, watch loop (Tasks 14-22) Signed-off-by: Tri Lam <trilamsr@gmail.com>
…(Tasks 21-25) Signed-off-by: Tri Lam <trilamsr@gmail.com>
…o extract, testifylint, forcetypeassert helper Signed-off-by: Tri Lam <trilamsr@gmail.com>
…OK/example_config (Tasks 26-27) Signed-off-by: Tri Lam <trilamsr@gmail.com>
Signed-off-by: Tri Lam <trilamsr@gmail.com>
…erred (Tasks 30-33) Signed-off-by: Tri Lam <trilamsr@gmail.com>
Contributor
Author
|
Closing in favor of stacked PRs A→B→C→D per post-shipping review (gap #11). Replacement: m14-a-rfc, m14-b-parser, m14-c-receiver, m14-d-bench. Each reviewable independently; merge order matches stack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Ships M14 (Kineto profiler receiver) end-to-end across the four phases of the M14 plan (plan is gitignored locally; design lives in RFC-0012 and the spec). Branch is one logical PR per autonomous-run constraint; split into 4 cuts before merge if preferred.
ProfilerStep#Ninterval, notargs.Iteration— falsified during design review against PyTorch source); sampling determinism (per-(rank, step) repeated-lookup equality, not cross-rank set equality; 10000 mod granularity); fr_trace analogy disclaimer.pkg/kineto/streaming Chrome-trace parser. stdlib-only, nointernal/imports. Typed sentinel errors,Synthesizedeterministic generator,toy_2stepchecked-in fixture + golden + SHA256SUMS,FuzzParseKinetoTrace30s in-tree,BenchmarkParse_50MBadvisory.make generate-fixtures-checkwired intomake ci.components/receivers/kineto/receiver: single-passProfilerStep#Nstack + complete-phase interval tracker,/proc/<pid>/environrank discovery (with filename-fallback fortensorboard_trace_handlerworker prefix; with receiver-env fallback), deterministic per-(rank, step) sampling, optionalcpu_opaggregation within a step, fsnotifyIN_CLOSE_WRITEtrigger (gz-aware glob),safe.Callwrap, degraded-state machine, README + RUNBOOK.components.yaml;cmd/tracecore/components.goregenerated.☐ → ☑ alpha; functional rubrics☑, non-functional⧗pending PR D wall-time runs.bench/overhead/kineto_bench_test.go(10-min CPU gate),soak_test.go(//go:build soak, 100 × 50MB RSS gate),stress_2gb_test.go(//go:build !race, 2GB HeapAlloc ceiling). Wall-time runs deferred — code lands, ops can flip rubrics once gates run.Verified during design (May 2026)
Cited verbatim in RFC-0012:
pytorch/pytorch torch/profiler/profiler.py:44, 651, 655, 1165-1169, 1230-1233—PROFILER_STEP_NAME, default filename{worker}.{ts_ns}.pt.trace.json, direct-writeexport_chrome_trace(no tmp+rename —IN_CLOSE_WRITEis the safe trigger),record_function(\"ProfilerStep#N\").pytorch/kineto libkineto/src/output_json.cpp:341-352, 543, 557, 580, 593— top-level key order;traceEventswritten betweenhandleTraceStartandfinalizeTrace; no top-levelsamplesorstackFrames(streaming-from-the-top decoder is safe).Test plan
Carry-forward
🤖 Generated with Claude Code