[docs] capture session-derived conventions: AGENTS.md + rfcs/README.md + notes/reviews.md#106
Merged
Conversation
The 5-pass review on RFC-0010 (PR #94) and the broader M15 session accumulated 11 binding rubric additions + 3 review-pattern lessons in session-ephemeral state that would have been lost when the worktree was cleaned. Promoting the load-bearing ones to durable docs. docs/rfcs/README.md additions: - §"Authoring conventions" — 8 binding rules for receiver-scope RFCs (Operator-surfaces section, Rubric-trace appendix, Performance budget, wire-attribute table, sibling-symbol compile-resolve, cross-RFC join-key resolution, post-fix symbol grep, FOLLOWUPS strikethrough). Each carries a falsifying grep/test. - §"Component registration" — the components.yaml + `make generate` codegen pattern documented for the next receiver author. docs/notes/reviews.md additions (matches existing format): - Multi-pass review accretes propagation gaps; grep after every applied fix. Anchor: RFC-0010 commit 63dccbb caught Phase-2 fixes that landed in one section and missed sibling sections. - Rubric self-violation sneaks in when the rubric is fresh. Anchor: Phase-2 accepted §Operator-surfaces rubric AND deferred the section in the same commit; Phase 4 caught it. - Single-maintainer projects collapse multi-stakeholder meeting processes to ~30-minute solo decision exercises. Anchor: RFC-0010 §15.6 framing presumed three stakeholders; resolved by one person. Closes the 4 documentation gaps surfaced in the session-summary audit. No code touched. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
…-index pointer Adds one load-bearing lesson and one topic-index pointer derived from the M15 / RFC-0010 review trail. Load-bearing lesson: - Cross-receiver join contracts resolve at design-lock, not at implementation-merge. Every `M-X emits Y` MILESTONES.md rubric is implicitly a contract with every `M-Z consumes Y` receiver. Before opening a receiver-scope RFC, grep for every attribute / label / field name introduced; reconcile divergences in-PR, not in a FOLLOWUPS row. Anchor: PR #94 (M15 RFC-0010) caught the tracecore.io/rank vs gen_ai.training.io/rank divergence with RFC-0009 in Phase-3 review and amended MILESTONES.md line 358 in the same PR. Topic-index pointer: - `docs/rfcs/README.md` — surfaces the receiver-scope RFC conventions (Operator surfaces, Rubric trace, Performance budget, wire-attribute table, cross-RFC join-key resolution, components.yaml codegen) promoted to that file in the body of this PR. Without the index entry, the next agent has to know the file exists. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The 5-pass review on RFC-0010 (PR #94) plus the broader M15 session accumulated 11 binding rubric additions + 3 review-pattern lessons in session-ephemeral state (gitignored
.claude/pr-review-loop.local.md) that would have been lost when the worktree was cleaned. Promoting the load-bearing ones to three durable surfaces:Changes
docs/rfcs/README.mdadditions§ Authoring conventions — 8 binding rules for receiver-scope RFCs, each carrying a falsifying grep / test:
(planned per …; not yet at HEAD)§ Component registration — the
components.yaml+make generatecodegen pattern documented for the next receiver author.docs/notes/reviews.mdadditions (matches existing format)63dccbb.AGENTS.mdadditionsM-X emits Yrubric is implicitly a contract with everyM-Z consumes Yreceiver. Grep MILESTONES.md before opening any receiver-scope RFC. Anchor: PR [docs] rfc-0010: containerstdout receiver scope (M15, alpha; design-locked draft) #94'stracecore.io/rankvsgen_ai.training.io/rankdivergence with RFC-0009.docs/rfcs/README.md— surfaces the receiver-scope RFC conventions added in this same PR so the next agent finds them.Test plan
make doc-checkclean (banned-phrase lint across 69 markdown files; link integrity verified).63dccbb,be3db09, PR [docs] rfc-0010: containerstdout receiver scope (M15, alpha; design-locked draft) #94) reachable on main.**Bold lesson title** body. Anchor: ...format.🤖 Generated with Claude Code