Problem
TestPatternDetector_NegativeFixturesEmitNoVerdicts/synthetic-2026-06-multi-rank-disk-pressure fails on origin/main (and on every branch downstream of #484 / f8b5419):
negative fixture synthetic-2026-06-multi-rank-disk-pressure must not emit verdicts
The detector fires three pod_evicted verdicts (full, full, partial) on the multi-rank disk-pressure fixture under module/pkg/replay/pod_evicted/_real_world/synthetic-2026-06-multi-rank-disk-pressure/ — which is the correct detection behaviour, but the fixture is shelved under _real_world/ and the test's filter (if f.Name == "canonical" { continue }) treats every non-canonical fixture as a negative.
Root cause
_real_world/ fixtures introduced in PR #484 are positive disk-pressure detection cases — they should NOT be in the negative-set the test enumerates. The filter needs to also skip _real_world/* entries (or move them into a _positive/ subtree the test consumes from a different harness).
Repro
(cd module && GOWORK=off go test -run TestPatternDetector_NegativeFixturesEmitNoVerdicts ./processor/patterndetectorprocessor/)
Discovered by
Surfaced while running module/ tests during the infra-triple-shipper PR (Makefile sharding + kind-CRD bootstrap + module/ lint coverage). Not caused by that PR — fails identically on origin/main HEAD.
Fix sketch
Update module/processor/patterndetectorprocessor/patterndetector_test.go::TestPatternDetector_NegativeFixturesEmitNoVerdicts to skip both canonical and _real_world/* entries; or split the helper into negative-only and positive-only fixture iterators keyed by the fixture's manifest `positive: bool` field (cleaner).
Problem
TestPatternDetector_NegativeFixturesEmitNoVerdicts/synthetic-2026-06-multi-rank-disk-pressurefails onorigin/main(and on every branch downstream of #484 /f8b5419):The detector fires three pod_evicted verdicts (full, full, partial) on the multi-rank disk-pressure fixture under
module/pkg/replay/pod_evicted/_real_world/synthetic-2026-06-multi-rank-disk-pressure/— which is the correct detection behaviour, but the fixture is shelved under_real_world/and the test's filter (if f.Name == "canonical" { continue }) treats every non-canonical fixture as a negative.Root cause
_real_world/fixtures introduced in PR #484 are positive disk-pressure detection cases — they should NOT be in the negative-set the test enumerates. The filter needs to also skip_real_world/*entries (or move them into a_positive/subtree the test consumes from a different harness).Repro
Discovered by
Surfaced while running module/ tests during the infra-triple-shipper PR (Makefile sharding + kind-CRD bootstrap + module/ lint coverage). Not caused by that PR — fails identically on
origin/mainHEAD.Fix sketch
Update
module/processor/patterndetectorprocessor/patterndetector_test.go::TestPatternDetector_NegativeFixturesEmitNoVerdictsto skip bothcanonicaland_real_world/*entries; or split the helper into negative-only and positive-only fixture iterators keyed by the fixture's manifest `positive: bool` field (cleaner).