Skip to content

test(patterndetector): cover SetDoubleValue + reverse-order cross-stream cases (#461 follow-ups) #463

Description

@trilamsr

Context

Surfaced by PR #461 review (closes #437). Two risk findings deferred as non-blocking:

  1. SetDoubleValue projection untested: All 10 projectFBMemoryFromMetrics test cases use `SetIntValue`. The truncation path `int64(dp.DoubleValue())` at `metrics.go:344` has no coverage. Add a test case with `SetDoubleValue` + assert correct integer projection.

  2. Reverse-order cross-stream join: `TestMetricsProcessor_CrossStreamJoinFragmentationVerdict` only feeds FB metric THEN OOM log. Reverse case (OOM before FB buffer populated) untested. Practical risk LOW (DCGM 15s scrape vs filelog sub-second = FB nearly always buffered first), but the implicit assumption should be locked. Add an out-of-order test that asserts the partial-verdict (`kind=unknown`) fallback fires correctly.

Refs

PR #461, issue #437.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions