Source: docs/followups/opportunistic.md row 8 (Next up).
runbook_kinds_test.go::resolveIncErrorCall (in components/receivers/kernelevents/) resolves IncError(kindFoo) (*ast.Ident) and IncError(selftelemetry.KindBar) (*ast.SelectorExpr) but not IncError(selftelemetry.Kind("foo")) (*ast.CallExpr cast). The kind would slip past the RUNBOOK parity check.
Trigger status (FIRED): call sites of selftelemetry.Kind("...") already exist in:
internal/selftelemetry/capturing_test.go:52
components/exporters/otlphttp/classify_internal_test.go:23,33,38
(None are inside an IncError(...) argument today, but the AST walker should still handle the cast form before a future caller introduces it.)
Files:
components/receivers/kernelevents/runbook_kinds_test.go — extend resolveIncErrorCall switch with *ast.CallExpr case, recognize selftelemetry.Kind("literal").
- Same file in any other receiver that copies the pattern.
Acceptance:
- Adding a test fixture
IncError(selftelemetry.Kind("test_kind")) in receiver.go surfaces "test_kind" in extractEmittedKinds.
- Existing RUNBOOK parity test still passes.
Note: the original follow-up cited the file as components/receivers/dcgm/runbook_kinds_test.go; correct path is components/receivers/kernelevents/runbook_kinds_test.go. DCGM uses docs_parity_test.go for an equivalent walker; both should grow the CallExpr handling.
Source:
docs/followups/opportunistic.mdrow 8 (Next up).runbook_kinds_test.go::resolveIncErrorCall(incomponents/receivers/kernelevents/) resolvesIncError(kindFoo)(*ast.Ident) andIncError(selftelemetry.KindBar)(*ast.SelectorExpr) but notIncError(selftelemetry.Kind("foo"))(*ast.CallExprcast). The kind would slip past the RUNBOOK parity check.Trigger status (FIRED): call sites of
selftelemetry.Kind("...")already exist in:internal/selftelemetry/capturing_test.go:52components/exporters/otlphttp/classify_internal_test.go:23,33,38(None are inside an
IncError(...)argument today, but the AST walker should still handle the cast form before a future caller introduces it.)Files:
components/receivers/kernelevents/runbook_kinds_test.go— extendresolveIncErrorCallswitch with*ast.CallExprcase, recognizeselftelemetry.Kind("literal").Acceptance:
IncError(selftelemetry.Kind("test_kind"))in receiver.go surfaces "test_kind" inextractEmittedKinds.Note: the original follow-up cited the file as
components/receivers/dcgm/runbook_kinds_test.go; correct path iscomponents/receivers/kernelevents/runbook_kinds_test.go. DCGM usesdocs_parity_test.gofor an equivalent walker; both should grow the CallExpr handling.