Make sure torch will only try to run as service when requested#576
Merged
Bishbash777 merged 1 commit intoTorchAPI:masterfrom Mar 22, 2024
Merged
Make sure torch will only try to run as service when requested#576Bishbash777 merged 1 commit intoTorchAPI:masterfrom
Bishbash777 merged 1 commit intoTorchAPI:masterfrom
Conversation
… the services.exe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this change, torch will try to run as a service if the environment is non-interactive and OS is not Windows Server 2019/2022, which is incorrect and will cause issues when being ran without GUI on other OSes.
This PR should Fix #449 by explicitly checking if process was started by services host and not the user.