Merged
Conversation
…e fix Co-authored-by: TimSoethout <593132+TimSoethout@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
This PR applies feedback from a previous review by moving the HideHelpCommand configuration from the root command to the appropriate subcommand level in a test. The PR also cleans up Go module dependency declarations by removing redundant indirect dependency listings and stale go.sum entries.
Changes:
- Moved
HideHelpCommand: truefrom root command tofrobblysubcommand inTestShowSubcommandHelp_GlobalOptions_HideHelpCommandtest - Removed explicit indirect dependencies declaration from docs/go.mod
- Cleaned up duplicate and outdated dependency entries from docs/go.sum
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| help_test.go | Correctly places HideHelpCommand: true on the frobbly subcommand instead of the root command, aligning with how the flag works (per-command, not inherited) |
| docs/go.mod | Removes unnecessary explicit require block for indirect dependencies |
| docs/go.sum | Removes duplicate and outdated dependency entries (old versions of BurntSushi/toml, stretchr/testify, urfave/cli-altsrc, gopkg.in/check.v1) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HideHelpCommand: truefrom the root command to thefrobblyleaf subcommand inTestShowSubcommandHelp_GlobalOptions_HideHelpCommand🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.