fix(help): show GLOBAL OPTIONS for leaf subcommands when HideHelpCommand is true#1
Merged
TimSoethout merged 1 commit intomainfrom Feb 26, 2026
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Fixes help rendering so leaf subcommands consistently use CommandHelpTemplate (and therefore show GLOBAL OPTIONS) even when HideHelpCommand removes the internal help subcommand and changes the raw subcommand count.
Changes:
- Update
helpCommandActionleaf-command detection to uselen(cmd.VisibleCommands()) == 0instead oflen(cmd.Commands)-based heuristics. - Add a regression test intended to cover
GLOBAL OPTIONSdisplay for--helpon a leaf subcommand whenHideHelpCommandis enabled.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
help.go |
Switches leaf detection to “visible subcommands == 0” to choose the command help template consistently. |
help_test.go |
Adds a test for GLOBAL OPTIONS rendering in the HideHelpCommand scenario. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes urfave#2268.
Root cause: help rendering selected template based on raw command count, which changes when HideHelpCommand hides the internal help subcommand.
Change: in helpCommandAction, leaf-command detection now uses visible commands (len(cmd.VisibleCommands()) == 0) so leaf subcommands consistently render with CommandHelpTemplate, including GLOBAL OPTIONS.
Tests: add TestShowSubcommandHelp_GlobalOptions_HideHelpCommand (modeled after TestShowSubcommandHelp_GlobalOptions).
Validation: go test ./... (full suite) passed.