Merged
Conversation
adding an import test without editing sys.path we should install via the package manager instead of relying on imports in the local directory
Collaborator
|
What do you mean by ears and badge? |
Collaborator
Author
ears is a discord-style decoration around the user's avatar (in comments). These are examples: ceebee (both badge and member) |
has_badge() is a function because it makes a new request each time also made the type checker happy with the typed dicts in _update_from_dict
This was referenced Dec 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
implements membership detections.
Solves issues #546 & #551
Changes
This
Tests
tests/test_membership.pyWarning
The tests are somewhat unrobust because they rely on certain scratch users not changing their configuration for their scratch membership, and assumes they are on a lifetime membership.
The tests may also fail if scratch changes the way that the badge is displayed. However, since it is literally an image with no class/id, there is likely not a more robust way to look for it.