Remove remix_tree related methods#530
Merged
faretek1 merged 2 commits intoTimMcCool:mainfrom Oct 22, 2025
Merged
Conversation
Signed-off-by: Boss-1s <95505913+Boss-1s@users.noreply.github.com>
Collaborator
|
the remixtree function was added by me a few weeks ago, after the current latest release to pypi. there's no need to use |
faretek1
requested changes
Oct 19, 2025
Collaborator
There was a problem hiding this comment.
there's a couple more things to remove
(looks like i can't manage to highlight the lines for the github review system, so i'll put some more funcnames/attrnames here):
These can be removed:
L50-51:
self.remix_tree_children: Optional[list[Project]] = None
self.remix_tree_parent: Optional[Project] = NoneL863
@property
def remix_depth(self) -> int:
"""
Get the 'remix depth' of this project - i.e. the number of layers of remixing until one reaches the remix root.
"""
if self.remix_tree_children is None:
self.remix_tree()
depth = 0
p = self
while p.remix_tree_parent:
# this could also be done recursively, but it can hit the recursion limit in extreme cases
# > and this happens often, because of remix chains
p = p.remix_tree_parent
depth += 1
return depthSigned-off-by: Boss-1s <95505913+Boss-1s@users.noreply.github.com>
Collaborator
|
Thanks, lgtm |
faretek1
added a commit
that referenced
this pull request
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves issue #529
Changes
Removed remix_tree and remix_tree_pretty_print
Tests
No tests needed
Maybe we could
@deprecateinstead, since not everyone knows that they removed the remixtree endpoint