Add note when encountering WebSocketBadStatusException#490
Merged
faretek1 merged 6 commits intoTimMcCool:mainfrom Sep 28, 2025
Merged
Add note when encountering WebSocketBadStatusException#490faretek1 merged 6 commits intoTimMcCool:mainfrom
faretek1 merged 6 commits intoTimMcCool:mainfrom
Conversation
Encountering a WebSocketBadStatusException most likely means that Scratch's cloud is down. Signed-off-by: Boss-1s <95505913+Boss-1s@users.noreply.github.com>
Collaborator
|
maybe add a note suggesting to try using tw Cloud. If the websocket error occurs when using tw cloud, then don't send the message |
faretek1
requested changes
Sep 27, 2025
Signed-off-by: retek <107722825+faretek1@users.noreply.github.com>
faretek1
reviewed
Sep 27, 2025
Collaborator
faretek1
left a comment
There was a problem hiding this comment.
I think there should be a check that we only show this message when it's a scratch cloud. If it's turbowarp cloud, just let the error exist.
Signed-off-by: Boss-1s <95505913+Boss-1s@users.noreply.github.com>
Contributor
Author
|
So if I did that, would we still need the message in the _base.py file? |
Collaborator
no. just need to check it work, and I'll merge |
Signed-off-by: TheCommCraft <79996518+TheCommCraft@users.noreply.github.com>
It seems like the scratch cloud variables are up again, so it can't really be tested anymore. On that note, we should test if new scratchers and banned accounts can still set cloud vars.
TheCommCraft
approved these changes
Sep 28, 2025
faretek1
approved these changes
Sep 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Encountering a WebSocketBadStatusException most likely means that Scratch's cloud is down, thus I have added a little note when a WebSocketBadStatusException is encountered when attempting to establish a WebSocket connection.
This could be improved on, I may make more edits later.
#487 (comment)
(Ignore failed workflow runs)