replace parent imports with first party imports#428
Merged
TheCommCraft merged 1 commit intomainfrom Jun 4, 2025
Merged
Conversation
Collaborator
|
got it. looks like i should edit scratchattach.editor to do this too? |
faretek1
approved these changes
Jun 4, 2025
Collaborator
faretek1
left a comment
There was a problem hiding this comment.
so long as it has been tested, it seems to be ok to merge
faretek1
reviewed
Jun 4, 2025
| def events(self, *, use_logs=False): | ||
| if self._session is None or use_logs: | ||
| from ..eventhandlers.cloud_events import CloudLogEvents | ||
| from scratchattach.eventhandlers.cloud_events import CloudLogEvents |
Collaborator
There was a problem hiding this comment.
is there a way to make this into a top-level import? Imports within functions are not ideal
faretek1
reviewed
Jun 4, 2025
| return None | ||
| from ..site import project | ||
| from ..utils import exceptions | ||
| from scratchattach.site import project |
Collaborator
There was a problem hiding this comment.
If possible, we should try to make these imports top-level
Collaborator
Author
There was a problem hiding this comment.
?
edit: oh yeah
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Absolute first party imports are encouraged to be used instead of relative parent imports.