Classroom property (solves #382)#405
Merged
faretek1 merged 5 commits intoTimMcCool:mainfrom May 30, 2025
Merged
Conversation
Collaborator
Author
Collaborator
Author
|
This would not conflict with any existing code, and has been tested on 3 accounts: import scratchattach as sa
u1 = sa.get_user("faretek1")
u2 = sa.get_user("l-_-o-_-i")
u3 = sa.get_user("tend-1")
print(u1.classroom)
print(u2.classroom)
print(u3.classroom)console: |
Collaborator
Author
|
Now checked that it works for detecting if a class is closed, and fixed a bug. import scratchattach as sa
u1 = sa.get_user("faretek1")
u2 = sa.get_user("l-_-o-_-i")
u3 = sa.get_user("tend-1")
print(u1.classroom)
print(u2.classroom.__dict__)
print(u3.classroom.__dict__)console: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

There is currently no way, only using scratchattach, to get the associated classroom of student accounts. It appears that there is no JSON site-api for this (or maybe I am just ignorant), however it is possible to work this out by viewing the
profile-details<p>tag in the profile page HTML.This PR implements a
site.user.User.classroomgetter method using the@propertydecorator and a cache attribute. As users can never change what class they are in, this cache value will never need to change, solving #382Details
The implementation uses bs4 to get the `` tag, and uses `soup.find_all("a")` and a RegEx for each href to detect which anchor refers to the classroom. The only possible other instance of an anchor tag being used in there is for becoming a scratcher, but I am not sure.
Note: The returned classroom object will only contain a classroom id and a classroom title (and a boolean if it is ended?)
todo: