Fix reporting comments on profiles#337
Conversation
I made report_comment use _assert_auth instead of _assert_permission so that you can report comments if you're not the profile owner. Signed-off-by: 50-scratch-tabs <197407676+50-scratch-tabs@users.noreply.github.com>
|
one of the main problems with the report api is that it is dangerous to test. i did see some ad spam earlier though, so that could be tested on |
Yes, I plan to test when I find spam. Keep an eye on griffpatch's profile once it opens back up. |
|
heres an example of a reportable comment: |
|
Is this good to merge? |
|
has it been tested? |
|
Tested with the spam comment linked earlier. If it gets removed we'll know it worked. |
|
If you report with three different accounts, the comment will automatically
be removed
50-scratch-tabs ***@***.***> schrieb am Do., 27. Feb. 2025,
00:18:
… Tested with the spam comment linked earlier. If it gets removed we'll know
it worked.
—
Reply to this email directly, view it on GitHub
<#337 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATCKMZSKGKHAZU77PJZ7KX32RZDUTAVCNFSM6AAAAABWLC3ZBGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBWGQZDGNZTGU>
.
You are receiving this because you commented.Message ID:
***@***.***>
[image: 50-scratch-tabs]*50-scratch-tabs* left a comment
(TimMcCool/scratchattach#337)
<#337 (comment)>
Tested with the spam comment linked earlier. If it gets removed we'll know
it worked.
—
Reply to this email directly, view it on GitHub
<#337 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ATCKMZSKGKHAZU77PJZ7KX32RZDUTAVCNFSM6AAAAABWLC3ZBGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMOBWGQZDGNZTGU>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
|
Tested with 3 accts, got removed instantly. Here's my quick and dirty code that I just ran in the shell: Worked like a charm. |
|
So did you try it with or without this PRs code? |
With. Without it just raises an exception unless it's your own profile. |
I made report_comment use _assert_auth instead of _assert_permission so that you can report comments if you're not the profile owner.
I haven't tested this yet. I will test it next time I see spammers on griffpatch's profile. Additionally, due to this bug, it seems like the report function has never been tested, so I'll compare the network output to that when I do it in browser.