[website] fixed navbar and added a new mobile menu. also fixed the codeboxes going off screen in the getting started section.#324
Merged
faretek1 merged 1 commit intoTimMcCool:mainfrom Jan 12, 2025
abhiramtx:main
Merged
[website] fixed navbar and added a new mobile menu. also fixed the codeboxes going off screen in the getting started section.#324faretek1 merged 1 commit intoTimMcCool:mainfrom abhiramtx:main
faretek1 merged 1 commit intoTimMcCool:mainfrom
abhiramtx:main
Conversation
…ing off screen on mobile.
Contributor
Author
|
menu can be toggled with the three dots in the corner, and is hidden when the user clicks on any of the buttons. |
Collaborator
|
seems to be good also lol @TheCommCraft Is this ok to merge? |
Contributor
Author
i had to make sure lol |
Collaborator
I think |
Owner
|
The changes from this PR are live now Edit: It seems like the PR somehow makes the header much narrower. I'll revert it for now and fix the problem tomorrow |
Contributor
Author
Forgot to change a vh value when testing, i'll submit another pr later, sorry |
Contributor
Author
|
That new one should fix it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed navbar and added a new mobile menu. also fixed the codeboxes going off screen in the getting started section.