Skip to content

Pop download_url from return_data of ProjectBody Asset#268

Merged
TimMcCool merged 1 commit intoTimMcCool:mainfrom
KR0K0BIL:asset_pop_download_url
Nov 8, 2024
Merged

Pop download_url from return_data of ProjectBody Asset#268
TimMcCool merged 1 commit intoTimMcCool:mainfrom
KR0K0BIL:asset_pop_download_url

Conversation

@KR0K0BIL
Copy link
Contributor

@KR0K0BIL KR0K0BIL commented Nov 2, 2024

A ProjectBody Asset sets self.download_url in the from_json function. The to_json function didn't remove this from return_data. It doesn't cause any problems, but since filename and id are removed, download_url should also be removed.

@TimMcCool TimMcCool merged commit ffb028a into TimMcCool:main Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants