Skip to content

해적 직업 추가 관련 수정이 필요합니다.#345

Merged
pinocchio22 merged 2 commits into
devfrom
fix/#344-ItemFilter
Jul 13, 2026
Merged

해적 직업 추가 관련 수정이 필요합니다.#345
pinocchio22 merged 2 commits into
devfrom
fix/#344-ItemFilter

Conversation

@pinocchio22

Copy link
Copy Markdown
Contributor

📌 이슈

✅ 작업 사항

'해적' 직업 추가에 따른 아이템 필터 선택지 추가
해적 / 너클 / 건 / 너클주문서 / 건주문서

'해적' 직업 추가에 따른 아이템 필터 선택지 추가
해적 / 너클 / 건 / 너클주문서 / 건주문서
@pinocchio22 pinocchio22 self-assigned this Jul 13, 2026
@pinocchio22 pinocchio22 added the fix 버그 수정, 잔잔바리 수정, 병합 시 충돌 해결 label Jul 13, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds support for the "해적" (Pirate) job class, including its corresponding weapons ("건", "너클") and scrolls, to the item filter feature. It also handles optional level ranges in the bottom sheet view controller. Feedback includes updating the unit tests to reflect that "해적" is now a valid job, and adjusting the default fallback value for the maximum level range from 0 to 200 to prevent displaying incorrect ranges like "레벨 10 ~ 0".

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@pinocchio22 pinocchio22 merged commit 603dbaa into dev Jul 13, 2026
2 checks passed
@pinocchio22 pinocchio22 deleted the fix/#344-ItemFilter branch July 13, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix 버그 수정, 잔잔바리 수정, 병합 시 충돌 해결

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant