Skip to content

피드백을 반영해 추천 기능을 수정합니다.#343

Merged
pinocchio22 merged 8 commits into
devfrom
fix/#341-RecommendationFeedback
Jul 12, 2026
Merged

피드백을 반영해 추천 기능을 수정합니다.#343
pinocchio22 merged 8 commits into
devfrom
fix/#341-RecommendationFeedback

Conversation

@pinocchio22

Copy link
Copy Markdown
Contributor

📌 이슈

✅ 작업 사항

  • 툴팁 미노출
  • 레벨 입력화면 미노출
  • 토스트 높이값 수정
  • 텍스트 잘림

@pinocchio22 pinocchio22 requested a review from dongglehada July 7, 2026 15:31
@pinocchio22 pinocchio22 self-assigned this Jul 7, 2026
@pinocchio22 pinocchio22 added feat 새로운 기능을 추가 fix 버그 수정, 잔잔바리 수정, 병합 시 충돌 해결 refactor 프로덕션 코드 리팩토링, 파일 삭제, 네이밍 수정 및 폴더링 labels Jul 7, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request restructures the main tab order, refactors the UserDefaultsRepository into feature-specific protocols to clean up dependency injection, and introduces a first-launch recommendation comment view and alert. The review feedback highlights several critical areas for improvement: resolving a potential race condition with the .showAlert event, avoiding static layout constants based on UIScreen.main to support screen rotation, and using flexible height constraints on Toast to prevent text truncation under Dynamic Type. Additionally, the reviewer recommends adding .distinctUntilChanged() to state bindings, optimizing UserDefaults writes, correcting a typo in DictionaryUserDefaultsRepository, and cleaning up redundant Task wrapping and long lines.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread MLS/MLSDesignSystem/Sources/MLSDesignSystem/Components/Toast.swift
Comment thread MLS/MLSAppFeature/Sources/MLSAppFeature/Launcher/AppLauncher.swift
@pinocchio22 pinocchio22 merged commit 442fd0d into dev Jul 12, 2026
2 checks passed
@pinocchio22 pinocchio22 deleted the fix/#341-RecommendationFeedback branch July 13, 2026 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feat 새로운 기능을 추가 fix 버그 수정, 잔잔바리 수정, 병합 시 충돌 해결 refactor 프로덕션 코드 리팩토링, 파일 삭제, 네이밍 수정 및 폴더링

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants