Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/five-sheep-grin.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@tanstack/router-plugin': patch
---

Initialize `import.meta.hot.data` before storing stable split components so Vitest does not crash when HMR data is missing.
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ const buildStableSplitComponentStatements = template.statements(
`
const %%stableComponentIdent%% = import.meta.hot?.data?.[%%hotDataKey%%] ?? %%lazyRouteComponentIdent%%(%%localImporterIdent%%, %%exporterIdent%%)
if (import.meta.hot) {
import.meta.hot.data ??= {}
import.meta.hot.data[%%hotDataKey%%] = %%stableComponentIdent%%
}
`,
Expand Down
33 changes: 33 additions & 0 deletions packages/router-plugin/tests/add-hmr.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -68,4 +68,37 @@ describe('add-hmr works', () => {
},
)
})

it('initializes import.meta.hot.data before storing stable split components', () => {
const code = `
import * as React from 'react'
import { createFileRoute } from '@tanstack/react-router'

export const Route = createFileRoute('/posts')({
component: component,
})

function component() {
return <div>posts</div>
}
`

const compileResult = compileCodeSplitReferenceRoute({
code,
filename: 'posts.tsx',
id: 'posts.tsx',
addHmr: true,
codeSplitGroupings: defaultCodeSplitGroupings,
targetFramework: 'react',
compilerPlugins: getReferenceRouteCompilerPlugins({
targetFramework: 'react',
addHmr: true,
}),
})

expect(compileResult?.code).toContain('import.meta.hot.data ??= {}')
expect(compileResult?.code).toContain(
'import.meta.hot.data["tsr-split-component:component"] = TSRSplitComponent',
)
})
})
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { createFileRoute } from '@tanstack/react-router';
import { fetchPosts } from '../posts';
const TSRSplitComponent = import.meta.hot?.data?.["tsr-split-component:component"] ?? lazyRouteComponent($$splitComponentImporter, "component");
if (import.meta.hot) {
import.meta.hot.data ??= {};
import.meta.hot.data["tsr-split-component:component"] = TSRSplitComponent;
}
export const Route = createFileRoute('/posts')({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ import { createFileRoute } from '@tanstack/react-router';
import { fetchPosts } from '../posts';
const TSRSplitComponent = import.meta.hot?.data?.["tsr-split-component:component"] ?? lazyRouteComponent($$splitComponentImporter, "component");
if (import.meta.hot) {
import.meta.hot.data ??= {};
import.meta.hot.data["tsr-split-component:component"] = TSRSplitComponent;
}
export const Route = createFileRoute('/posts')({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,12 @@ import { createFileRoute } from '@tanstack/react-router';
import { fetchPosts } from '../posts';
const TSRSplitComponent = import.meta.hot?.data?.["tsr-split-component:component"] ?? lazyRouteComponent($$splitComponentImporter, "component");
if (import.meta.hot) {
import.meta.hot.data ??= {};
import.meta.hot.data["tsr-split-component:component"] = TSRSplitComponent;
}
const TSRSplitErrorComponent = import.meta.hot?.data?.["tsr-split-component:errorComponent"] ?? lazyRouteComponent($$splitErrorComponentImporter, "errorComponent");
if (import.meta.hot) {
import.meta.hot.data ??= {};
import.meta.hot.data["tsr-split-component:errorComponent"] = TSRSplitErrorComponent;
}
export const Route = createFileRoute('/posts')({
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,12 @@ import { createFileRoute } from '@tanstack/react-router';
import { fetchPosts } from '../posts';
const TSRSplitComponent = import.meta.hot?.data?.["tsr-split-component:component"] ?? lazyRouteComponent($$splitComponentImporter, "component");
if (import.meta.hot) {
import.meta.hot.data ??= {};
import.meta.hot.data["tsr-split-component:component"] = TSRSplitComponent;
}
const TSRSplitErrorComponent = import.meta.hot?.data?.["tsr-split-component:errorComponent"] ?? lazyRouteComponent($$splitErrorComponentImporter, "errorComponent");
if (import.meta.hot) {
import.meta.hot.data ??= {};
import.meta.hot.data["tsr-split-component:errorComponent"] = TSRSplitErrorComponent;
}
export const Route = createFileRoute('/posts')({
Expand Down
Loading