Skip to content

fix(router): catch stringifyParams errors and render errorComponent #6718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Sheraff merged 2 commits into from
Feb 21, 2026
Merged

fix(router): catch stringifyParams errors and render errorComponent #6718

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f7f39d
fix(router): catch stringifyParams errors and render errorComponent
TheAbMehta Feb 21, 2026
d178f80
refactor: clarify catch comment for unpaired stringifyParams case
TheAbMehta Feb 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions packages/router-core/src/router.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1883,8 +1883,16 @@ export class RouterCore<
const fn =
route.options.params?.stringify ?? route.options.stringifyParams
if (fn) {
changedParams = true
Object.assign(nextParams, fn(nextParams))
try {
Object.assign(nextParams, fn(nextParams))
changedParams = true
} catch {
// Ignore errors here. When a paired parseParams is defined,
// extractStrictParams will re-throw during route matching,
// storing the error on the match and allowing the route's
// errorComponent to render. If no parseParams is defined,
// the stringify error is silently dropped.
}
}
}
}
Expand Down
Loading