fix: pyright errors in blender_renderer.py #1236
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
This does appear to be working with files that don't have a thumbnail. 
The terminal also prints out the correct output: |
Collaborator
Author
Thank you for testing that! Are you able to share the |
Contributor
|
You can create your own! You can click on "File -> Save as" and then tick "Compress" on the pull out side menu, removing the thumbnail on the file you will save. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Progress towards #1061 and #1232 by fixing the errors in blender_renderer.py.
NOTE: I can confirm that blender thumbnails still work, however, I don't have a
.blendfile without a thumbnail (and couldn't figure out how to create one) so I wasn't able to test that.Tasks Completed