fix: no light-alt in auto colors#627
Merged
Merged
Conversation
Review Summary by QodoAdd missing light-alt accent color variable
WalkthroughsDescription• Add missing --global-color-accent--light-alt CSS variable • Define intermediate light accent color using oklab formula • Enables proper footer link styling in dark contexts Diagramflowchart LR
A["CSS Variables"] -- "add light-alt" --> B["--global-color-accent--light-alt"]
B -- "oklab formula" --> C["Intermediate Light Color"]
C -- "enables" --> D["Footer Purple Links"]
File Changes1. src/lib/_imports/settings/color--cms.auto.css
|
Code Review by Qodo
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Add
--global-color-accent--light-alttocolor--cms.auto.css.Related
Changes
--global-color-accent--light-altmathTesting
Via TACC/Core-CMS-Custom#531, verify footer has purple links.
UI