Skip to content

feat: support image cards in a card list#484

Merged
wesleyboar merged 4 commits into
mainfrom
fix/images-in-cards-in-card-list-can-overflow
Mar 25, 2025
Merged

feat: support image cards in a card list#484
wesleyboar merged 4 commits into
mainfrom
fix/images-in-cards-in-card-list-can-overflow

Conversation

@wesleyboar

@wesleyboar wesleyboar commented Mar 25, 2025

Copy link
Copy Markdown
Member

Overview

  • Use c-card-list (instead of s-image-card) for Card demo.
  • Prevent images in cards in card list from overflowing.

Related

Changes

  • changed c-card-lists-image-card
  • added max-width for card list card images

Testing

  1. Open http://localhost:3000/components/preview/c-card--images.
  2. Verify cards are in a grid.
  3. Verify grid is always two columns wide.

UI

card demo using card list not image grid

@wesleyboar wesleyboar changed the title fix: images in cards in card list can overflow fix: support image cards in a card list Mar 25, 2025
@wesleyboar wesleyboar changed the title fix: support image cards in a card list feat: support image cards in a card list Mar 25, 2025
@wesleyboar
wesleyboar merged commit d68041c into main Mar 25, 2025
@wesleyboar
wesleyboar deleted the fix/images-in-cards-in-card-list-can-overflow branch March 25, 2025 01:56
wesleyboar added a commit that referenced this pull request Mar 25, 2025
@wesleyboar wesleyboar mentioned this pull request Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant