Skip to content

feat(v3): pagination#451

Merged
wesleyboar merged 25 commits into
epic/v3--reorgfrom
epic/v3--reorg--pagination
Feb 17, 2025
Merged

feat(v3): pagination#451
wesleyboar merged 25 commits into
epic/v3--reorgfrom
epic/v3--reorg--pagination

Conversation

@wesleyboar

@wesleyboar wesleyboar commented Feb 15, 2025 •
edited
Loading

Copy link
Copy Markdown
Member

Overview

Support Bootstrap, DjangoCMS Blog, and TACC, and mixin pagination.

Related

  • will this conflict with epic/v3--reorg--bs4-more-wip?

Changes

  • added pagination mixin
  • added pagination clients
  • updated pagination instances to use mixin

Testing

  1. Bootstrap4: Pagination
  2. DjangoCMS Blog: Pagination
  3. Components: Pagination
  4. Tools: Pagination

UI

mixin bootstrap4
x-pagination bootstrap4 pagination
c-page cms blog
c-page cms blog pagination

@wesleyboar
feat(djangocms-blog): pagination
89841fc
@wesleyboar
feat(pagination): WIP See TODO and XXX
b87be86 
- 🚧 bootstrap4 .pagination
    - ✅ default
    - 🐞 tacc (CMS/Portal)
        - UI bugs
        - consider combining
- ✅ djangocms-blog .pagination
- ❌ TACC .c-page
    - deleted out of ignorance
    - must be restored
    - reference provided
@wesleyboar wesleyboar added feature A new feature or replacement of existing feature enhancement Improvements or additions to existing features refactor Re-writes/structures code but retains behavior minor A feature in backward-compatible manner and removed feature A new feature or replacement of existing feature labels Feb 15, 2025
@wesleyboar
fix(pagination): skin (color, border, outline, …)
7ba42f6 
- 💡 bootstrap4 .pagination
    - ✅ default
    - ✅ tacc (CMS/Portal)
        - 💡 consider combining
- ✅ djangocms-blog .pagination
- ❌ TACC .c-page
    - deleted out of ignorance
    - must be restored
    - reference provided
@wesleyboar
refactor(pagination): link vs link--end
bcb021d
@wesleyboar
docs(pagination): TODO @import x-link x-button
b199a3d
@wesleyboar
refactor(pagination): __item & __link → vs __…-item & __…-link
19d4a58
@wesleyboar wesleyboar force-pushed the epic/v3--reorg--pagination branch from c513fd2 to 19d4a58 Compare February 16, 2025 02:19
@wesleyboar
fix(pagination): skipped bootstrap link blue
d4cd2de
@wesleyboar
chore(pagination): re-order style and remove cruft
a3392a9
@wesleyboar
fix(pagination): button (as link) looses width
f94f955
@wesleyboar
refactor(pagination): assume links are <a>
df26eaf
@wesleyboar
enhance(pagination): edge cases
5139a24
@wesleyboar
fix(pagination): cms & portal match but are split
d97bb4f
@wesleyboar
fix(pagination): easy button links & square links
33c942f
@wesleyboar
fix(c-page): restore
e4a29f3
@wesleyboar
fix(c-page): restore it as it was, no c-pagination
33d5cc2
@wesleyboar
feat(pagination): tools/x-pagination demo
6a3f0c2
@wesleyboar
fix(pagination): consistent border-radius
ccc1fbf 
- components/c-page
- bootstrap4/pagination
- tools/x-pagination
@wesleyboar
fix(pagination): consistent skip/etc links
d920d3e
@wesleyboar
refactor(pag…): disabled/active links → modifiers
c5e1af5
@wesleyboar
enhance(pagination): disabled link for c-page
08f5cb0
@wesleyboar
fix(pag…): c-page should NOT use button class
bcde2e0
@wesleyboar
fix(pag…): list too tall, inconsistentent w/ x-…
adcdd86
@wesleyboar wesleyboar changed the title 🚧 feat(v3): pagination — WIP, see TODO & XXX feat(v3): pagination Feb 17, 2025
@wesleyboar wesleyboar marked this pull request as ready for review February 17, 2025 21:35
@wesleyboar wesleyboar merged commit b8c2c2f into epic/v3--reorg Feb 17, 2025
@wesleyboar wesleyboar deleted the epic/v3--reorg--pagination branch February 17, 2025 21:53
@wesleyboar wesleyboar added minor A feature in backward-compatible manner and removed minor A feature in backward-compatible manner labels Feb 18, 2025
wesleyboar added a commit that referenced this pull request Mar 4, 2025
@wesleyboar
feat(v2): pagination (retrofit #451)
6ef1995
@wesleyboar wesleyboar mentioned this pull request Mar 4, 2025
Merged
wesleyboar added a commit that referenced this pull request Mar 4, 2025
@wesleyboar
feat(v2): pagination (retrofit #451) (#473)
2844495
@wesleyboar wesleyboar moved this to Done in Core Styles v3 Oct 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

enhancement Improvements or additions to existing features minor A feature in backward-compatible manner refactor Re-writes/structures code but retains behavior

Projects

Core Styles v3
Status: Done

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@wesleyboar