Skip to content

refactor!: djangocms_picture extension#969

Merged
wesleyboar merged 36 commits into
mainfrom
refactor/djangocms_picture
Jul 26, 2025
Merged

refactor!: djangocms_picture extension#969
wesleyboar merged 36 commits into
mainfrom
refactor/djangocms_picture

Conversation

@wesleyboar

@wesleyboar wesleyboar commented Jul 25, 2025

Copy link
Copy Markdown
Member

Overview

Refactor/Simplify customization of:

  • djangocms_picture
  • djangocms_bootstrap4's bootstrap4_picture

Warning

Incompatible with previous PRs since last release, but still compatible with previous release.

Related

Changes

  • deletes logging
  • deletes excess templates
  • deletes excess template blocks
  • adds more context variables to view
  • changes our default template to need zero overrides
  • changes other templates to only extend default and comment
  • deletes unused templates

Testing

  1. Build test case of every relevant configuration of an image.
  2. Verify behavior of all configurations matches that on main branch.

Tip

To create these test cases, import
plugins (via djangocms_transfer which is installed in Core-CMS), but before import change value in "data" of:

  • "picture" to the ID of a picture in your test CMS - "external_picture" to a URL of any different image
  • "link_page" to the ID of a page in your CMS
  • "internal_link" to the ID of a page in your CMS

UI

default.template.internal.image.mov
no_link_to_image.template.external.image.mov
zoom_effect.template.internal.image.mov
zoom_effect_no_link_to_ext_image.template.external.image.mov

Tip

To emulate the debug overlay UI, add a snippet with:

<link rel="stylesheet" href="https://cdn.jsdelivr.net/gh/TACC/Core-CMS@5a42643b/taccsite_cms/static/site_cms/css/test/djangocms-picture.css">

@wesleyboar wesleyboar changed the title Refactor/djangocms picture refactor: our extension of djangocms_picture Jul 25, 2025
@wesleyboar wesleyboar changed the title refactor: our extension of djangocms_picture refactor: djangocms_picture extension Jul 25, 2025
@wesleyboar wesleyboar changed the title refactor: djangocms_picture extension refactor!: djangocms_picture extension Jul 26, 2025
@wesleyboar wesleyboar marked this pull request as ready for review July 26, 2025 01:12
@wesleyboar wesleyboar merged commit 5ec5e02 into main Jul 26, 2025
@wesleyboar wesleyboar deleted the refactor/djangocms_picture branch July 26, 2025 01:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant