refactor!: djangocms_picture extension#969
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Refactor/Simplify customization of:
djangocms_picturedjangocms_bootstrap4'sbootstrap4_pictureWarning
Incompatible with previous PRs since last release, but still compatible with previous release.
Related
(and older PRs that introduced related code)
Changes
Testing
mainbranch.Tip
To create these test cases, import
plugins(via djangocms_transfer which is installed in Core-CMS), but before import change value in"data"of:"picture"to the ID of a picture in your test CMS -"external_picture"to a URL of any different image"link_page"to the ID of a page in your CMS"internal_link"to the ID of a page in your CMSUI
default.template.internal.image.mov
no_link_to_image.template.external.image.mov
zoom_effect.template.internal.image.mov
zoom_effect_no_link_to_ext_image.template.external.image.mov
Tip
To emulate the debug overlay UI, add a snippet with: