Skip to content

feat: do not force picture to be link if it has external image#925

Merged
wesleyboar merged 5 commits into
mainfrom
feat/let-admin-tell-picture-with-ext-image-to-not-force-link
Apr 7, 2025
Merged

feat: do not force picture to be link if it has external image#925
wesleyboar merged 5 commits into
mainfrom
feat/let-admin-tell-picture-with-ext-image-to-not-force-link

Conversation

@wesleyboar

@wesleyboar wesleyboar commented Mar 25, 2025

Copy link
Copy Markdown
Member

Overview

A Picture that has an external image usually becomes a link, until now.

This adds a Template for picture that lets admin prevent link.

Related

Changes

  • updates core-styles
  • adds setting to customize Picture template choices
  • adds blocks to default Picture template
  • adds new template for Picture

Testing

  1. Create Link.
  2. Create Image/Picture in link.
  3. Set External Image for Image/Picture instance.
  4. Verify the Image/Picture renders inside Link i.e. is not extracted and given its own link.

UI

After Core-Styles v2.41.0

Image Creates Link to Image vs. Link as a Card links Card+Image to Path

(problem) media in card links to media (solution) link as a card links to path
image links to image card links to path

Use Image/Picture Template

(problem) media in card links to media (solution) link as a card links to path
linked picture image in a linked card
linked image picture in a linked card
card.as.link.mov
Before Core-Styles v2.41.0
not styled yet styled
(requires TACC/Core-Styles#485)
card link with image - unstyled

@wesleyboar wesleyboar marked this pull request as draft March 25, 2025 19:38
@wesleyboar wesleyboar marked this pull request as ready for review April 7, 2025 21:28
@wesleyboar wesleyboar merged commit f5f701e into main Apr 7, 2025
@wesleyboar wesleyboar deleted the feat/let-admin-tell-picture-with-ext-image-to-not-force-link branch April 7, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant